[cpp-sp] branch main updated: Correct misuse of temp objects.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/6294901b0aa6b264f2107db3d2b07acedf37e7c7

The following commit(s) were added to refs/heads/main by this push:
     new 6294901b Correct misuse of temp objects.
6294901b is described below

commit 6294901b0aa6b264f2107db3d2b07acedf37e7c7
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Thu Oct 1 12:50:27 2026 -0400

    Correct misuse of temp objects.
---
 shibsp/session/impl/FilesystemSessionCache.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/shibsp/session/impl/FilesystemSessionCache.cpp b/shibsp/session/impl/FilesystemSessionCache.cpp
index 1d8c1058..8ff26bbf 100644
--- a/shibsp/session/impl/FilesystemSessionCache.cpp
+++ b/shibsp/session/impl/FilesystemSessionCache.cpp
@@ -330,7 +330,8 @@ DDF FilesystemSessionCache::cache_read(
         DDF in = remoting->build("sealer", nullptr, request ? request->getRequestID() : nullptr);
         DDFJanitor injanitor(in);
 
-        in.addmember("decrypt").list().add(DDF(nullptr).string(buf));
+        DDF child(nullptr);
+        in.addmember("decrypt").list().add(child.string(buf));
 
         DDF out = remoting->send(in);   // let this throw to caller
         DDFJanitor outjanitor(out);
@@ -530,7 +531,7 @@ bool FilesystemSessionCache::cache_touch(SPRequest* request, const char* key, un
     // If we get here, we have the effective variables are set correctly.
 
     if (timeout && effective_access + timeout < time(nullptr)) {
-        if (m_spilog.isInfoEnabled()) {
+        if ((request && request->isPriorityEnabled(Priority::SHIB_INFO)) || m_spilog.isInfoEnabled()) {
             string ts(date::format("%FT%TZ", chrono::system_clock::from_time_t(effective_access)));
             log(INFO_MARK, "session (%s) expired for inactivity, timeout (%lu), last access (%s)", key, timeout, ts.c_str());
         }
@@ -578,7 +579,8 @@ void FilesystemSessionCache::store_session(SPRequest* request, const char* path,
 
         ostringstream sink;
         sink << sessionData;
-        in.addmember("encrypt").list().add(DDF(nullptr).string(sink.str()));
+        DDF child(nullptr);
+        in.addmember("encrypt").list().add(child.string(sink.str()));
 
         DDF out = remoting->send(in);   // let this throw to caller
         DDFJanitor outjanitor(out);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.