[cpp-sp] branch main updated: Fix handling of touch operation result.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/952d353a97be5eda09c630087c5306f7966e5b6e

The following commit(s) were added to refs/heads/main by this push:
     new 952d353a Fix handling of touch operation result.
952d353a is described below

commit 952d353a97be5eda09c630087c5306f7966e5b6e
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Thu Oct 1 11:01:57 2026 -0400

    Fix handling of touch operation result.
---
 shibsp/session/impl/StorageServiceSessionCache.cpp | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/shibsp/session/impl/StorageServiceSessionCache.cpp b/shibsp/session/impl/StorageServiceSessionCache.cpp
index ed85c98e..82bfea79 100644
--- a/shibsp/session/impl/StorageServiceSessionCache.cpp
+++ b/shibsp/session/impl/StorageServiceSessionCache.cpp
@@ -94,6 +94,8 @@ StorageServiceSessionCache::~StorageServiceSessionCache()
 
 string StorageServiceSessionCache::cache_create(SPRequest* request, const char*, DDF& sessionData)
 {
+    // Note the candidate key is ignored as the Hub will generate one itself.
+
     const RemotingService* remoting = AgentConfig::getConfig().getAgent().getRemotingService();
     DDF in = remoting->build("session-cache", nullptr, request ? request->getRequestID() : nullptr);
     DDFJanitor injanitor(in);
@@ -313,9 +315,10 @@ bool StorageServiceSessionCache::cache_touch(SPRequest* request, const char* key
         in.addmember("timeout").integer(timeout);
     }
 
-    DDF out;
     try {
-        out = remoting->send(in);
+        DDF out = remoting->send(in);
+        // No output, success is just implicit.
+        out.destroy();
     }
     catch (const OperationException& e) {
         // Check for policy events.
@@ -342,12 +345,7 @@ bool StorageServiceSessionCache::cache_touch(SPRequest* request, const char* key
         throw;
     }
 
-    DDFJanitor outjanitor(out);
-
-    if (out.getmember("key").isstring()) {
-        return true;
-    }
-    return false;
+    return true;
 }
 
 void StorageServiceSessionCache::cache_remove(SPRequest* request, const char* key)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.