[java-idp-plugin-vci] branch dev/REVISSFLOW updated: Less verbose commenting on beans

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch dev/REVISSFLOW
in repository java-idp-plugin-vci.

View the commit online:
https://codeberg.org/Shibboleth/java-idp-plugin-vci/commit/f4cd676f5fa1322705305c233549c4b08c10db91

The following commit(s) were added to refs/heads/dev/REVISSFLOW by this push:
     new f4cd676  Less verbose commenting on beans
f4cd676 is described below

commit f4cd676f5fa1322705305c233549c4b08c10db91
Author: Janne Lauros <janne.lauros at csc.fi>
AuthorDate: Fri Nov 6 15:38:17 2026 +0200

    Less verbose commenting on beans
---
 .../META-INF/net.shibboleth.idp/postconfig.xml     | 30 +++-------------------
 1 file changed, 4 insertions(+), 26 deletions(-)

diff --git a/openid-vci-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml b/openid-vci-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
index 362bbe4..ec824ab 100644
--- a/openid-vci-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
+++ b/openid-vci-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
@@ -92,18 +92,7 @@
         c:resolver-ref="openidvci.CredentialConfigurationsResolver" />
     
 
-    <!--
-    Resolver of the Credential Issuer metadata this deployment publishes. The document is
-    read from a file, apart from the members resolved outside it. Deployer may replace the
-    whole file with bean "openidvci.CredentialIssuerMetadata", or point
-    openidvci.issuerMetadata.template at another path.
-
-    The file is a Velocity template, so that the urls in it name this host without the file
-    being edited. Variables are $issuer, $baseUrl and $host, all derived from the issuer of
-    the OP. Define map bean "openidvci.issuerMetadata.TemplateContext" to add variables or
-    to replace those three. A document that carries '$' or '#' as content needs
-    openidvci.issuerMetadata.templated set to false, Velocity reads both of them.
-    -->
+    <!-- Credential Issuer metadata, published at /.well-known/openid-credential-issuer. -->
     <bean id="openidvci.DefaultCredentialIssuerMetadataResolver" lazy-init="true"
         class="org.geant.shibboleth.plugin.openidvci.metadata.impl.DynamicFilesystemCredentialIssuerMetadataResolver"
         depends-on="shibboleth.LoggingService"
@@ -119,11 +108,7 @@
     <bean id="openidvci.IssuerMetadataSkeleton" class="org.springframework.core.io.FileSystemResource" lazy-init="true"
         c:path="%{openidvci.issuerMetadata.template:%{idp.home}/static/openid-credential-issuer.json}" />
 
-    <!--
-    Members of the published document resolved outside the metadata file, keyed by the
-    member each resolver serves. A resolved value replaces the one in the file, so the file
-    does not have to carry the member at all.
-    -->
+    <!-- Members of the Credential Issuer metadata resolved outside the file, keyed by member. -->
     <bean id="openidvci.issuerMetadata.DefaultDynamicValueResolvers" lazy-init="true"
         class="org.springframework.beans.factory.config.MapFactoryBean">
         <property name="sourceMap">
@@ -134,21 +119,14 @@
         </property>
     </bean>
 
-    <!--
-    Credential Configurations are published from the same file that instructs how a
-    credential is formed, so that what is advertised is what can be issued. This only
-    adapts the resolver below to a metadata member.
-    -->
+    <!-- credential_configurations_supported of the Credential Issuer metadata, from the Credential Configurations. -->
     <bean id="openidvci.issuerMetadata.CredentialConfigurationsResolver" lazy-init="true"
         class="org.geant.shibboleth.plugin.openidvci.metadata.impl.CredentialConfigurationsValueResolver"
         depends-on="shibboleth.LoggingService"
         p:id="openidvci.issuerMetadata.CredentialConfigurationsResolver"
         c:credentialConfigurations-ref="openidvci.CredentialConfigurationsResolver" />
 
-    <!--
-    Credential Configurations of this deployment. Every flow reading them shares this, the
-    file is read when it changes rather than once per request.
-    -->
+    <!-- Credential Configurations of this deployment, shared by every flow. -->
     <bean id="openidvci.CredentialConfigurationsResolver" lazy-init="true"
         class="org.geant.shibboleth.plugin.openidvci.credential.impl.FilesystemCredentialConfigurationsResolver"
         depends-on="shibboleth.LoggingService"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.