[java-plugin-shibd] branch main updated: Stop injecting possibly duplicate agent mappings.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd/commit/872e562908b84d330a7a23d61434036691f8828b

The following commit(s) were added to refs/heads/main by this push:
     new 872e562  Stop injecting possibly duplicate agent mappings.
872e562 is described below

commit 872e562908b84d330a7a23d61434036691f8828b
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Mon Nov 2 19:46:02 2026 -0500

    Stop injecting possibly duplicate agent mappings.
---
 .../java/net/shibboleth/sp/impl/DefaultAgentResolver.java  | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/sp-server-impl/src/main/java/net/shibboleth/sp/impl/DefaultAgentResolver.java b/sp-server-impl/src/main/java/net/shibboleth/sp/impl/DefaultAgentResolver.java
index 6146028..ef6244c 100644
--- a/sp-server-impl/src/main/java/net/shibboleth/sp/impl/DefaultAgentResolver.java
+++ b/sp-server-impl/src/main/java/net/shibboleth/sp/impl/DefaultAgentResolver.java
@@ -75,17 +75,13 @@ public class DefaultAgentResolver extends IdentifiedComponentManager<Agent> impl
             }
             
             for (final Map.Entry<String,String> creds : agent.getCredentials().entrySet()) {
-                final String key = creds.getKey();
-                if (key != null) {
-                    if (agentMap.containsKey(key)) {
-                        log.warn("Ignoring duplicate mapping for Agent username: {}", key);
+                final String altname = creds.getKey();
+                if (altname != null) {
+                    if (agentMap.containsKey(altname)) {
+                        log.warn("Ignoring duplicate mapping for Agent username: {}", altname);
                     } else {
-                        agentMap.put(key, agent);
+                        agentMap.put(altname, agent);
                     }
-                } else {
-                    // This may involve duplicates, but we know they're all for this Agent since
-                    // the map was checked above for the Agent ID.
-                    agentMap.put(agent.getId(), agent);
                 }
             }
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.