[cpp-sp] 01/03: Fix double logging of context string.

Codeberg noreply at shibboleth.net
Thu May 28 18:46:38 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/a5a78fdbaf244d013542730eb0336324c494de47

commit a5a78fdbaf244d013542730eb0336324c494de47
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Thu May 28 14:45:32 2026 -0400

    Fix double logging of context string.
---
 shibsp/AbstractSPRequest.cpp | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/shibsp/AbstractSPRequest.cpp b/shibsp/AbstractSPRequest.cpp
index 6c9d160c..3dfa968f 100644
--- a/shibsp/AbstractSPRequest.cpp
+++ b/shibsp/AbstractSPRequest.cpp
@@ -467,13 +467,9 @@ const char* AbstractSPRequest::getLogContext() const{
 
 void AbstractSPRequest::log(Priority::Value level, const exception& e) const
 {
-    const char* ctx = getLogContext();
     const AgentException* rich_ex = dynamic_cast<const AgentException*>(&e);
     if (rich_ex) {
         ostringstream msg;
-        if (ctx) {
-            msg << ctx << ' ';
-        }
         msg << e.what() << " [";
 
         // Dump properties and status code.
@@ -489,11 +485,6 @@ void AbstractSPRequest::log(Priority::Value level, const exception& e) const
 
         log(level, msg.str());
     }
-    else if (ctx) {
-        string s(ctx);
-        s = s + ' ' + e.what();
-        log(level, s);
-    }
     else {
         log(level, e.what());
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list