[java-plugin-shibd-saml] branch main updated: Fix unit test due to another sealing violation.

Codeberg noreply at shibboleth.net
Mon May 25 15:12:36 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd-saml.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-saml/commit/f8e3488b4a0f9384e70e568f6575474f39665f72

The following commit(s) were added to refs/heads/main by this push:
     new f8e3488  Fix unit test due to another sealing violation.
f8e3488 is described below

commit f8e3488b4a0f9384e70e568f6575474f39665f72
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Mon May 25 11:12:12 2026 -0400

    Fix unit test due to another sealing violation.
---
 .../sp/saml/saml2/profile/impl/ProcessLogoutInitiatorRequest.java  | 5 +++--
 .../sp/saml/saml2/profile/impl/ProcessLogoutRequestTest.java       | 7 ++-----
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutInitiatorRequest.java b/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutInitiatorRequest.java
index a707ff9..6d9ec27 100644
--- a/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutInitiatorRequest.java
+++ b/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutInitiatorRequest.java
@@ -91,7 +91,7 @@ public class ProcessLogoutInitiatorRequest extends AbstractApplicationAction {
     public void setParserPool(@Nonnull final ParserPool pool) {
         checkSetterPreconditions();
         
-        parserPool = pool;
+        parserPool = Constraint.isNotNull(pool, "ParserPool cannot be null");
     }
     
     /**
@@ -172,7 +172,8 @@ public class ProcessLogoutInitiatorRequest extends AbstractApplicationAction {
     }
     
     /** {@inheritDoc} */
-    @Override protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext) {
+    @Override
+    protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext) {
 
         final SAMLLogoutContext logoutContext = profileRequestContext.ensureSubcontext(SAMLLogoutContext.class);
         nameID.setSPProvidedID(null);
diff --git a/sp-saml-impl/src/test/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutRequestTest.java b/sp-saml-impl/src/test/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutRequestTest.java
index 1f3970e..e559e66 100644
--- a/sp-saml-impl/src/test/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutRequestTest.java
+++ b/sp-saml-impl/src/test/java/net/shibboleth/sp/saml/saml2/profile/impl/ProcessLogoutRequestTest.java
@@ -49,7 +49,6 @@ import net.shibboleth.shared.xml.impl.BasicParserPool;
 import net.shibboleth.sp.ddf.DDF;
 import net.shibboleth.sp.profile.ConsumerConstants;
 import net.shibboleth.sp.profile.impl.BaseApplicationActionTest;
-import net.shibboleth.sp.profile.impl.CreateOutputMessage;
 import net.shibboleth.sp.saml.saml2.SAMLStateData;
 import net.shibboleth.sp.state.impl.PassthroughStateManager;
 import net.shibboleth.sp.testing.TestResourceConverter;
@@ -126,10 +125,8 @@ public class ProcessLogoutRequestTest extends BaseApplicationActionTest {
         action.setParserPool(parserPool);
         action.setStateManager(stateManager);
         action.initialize();
-        
-        final CreateOutputMessage prep = new CreateOutputMessage();
-        prep.initialize();
-        ActionTestingSupport.assertProceedEvent(prep.execute(src));
+
+        arc.setOutput(new DDF(null).structure());
         
         buildLogoutRequest();
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list