[java-shib-profile] 02/02: JSSH-71 Remove the impact of the DestructableComponent Interface

Codeberg noreply at shibboleth.net
Fri May 22 16:09:05 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch dev/JSSH-71
in repository java-shib-profile.

View the commit online:
https://codeberg.org/Shibboleth/java-shib-profile/commit/978431552795d438744152f73e29aee25f5680b8

commit 978431552795d438744152f73e29aee25f5680b8
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri May 22 17:08:46 2026 +0100

    JSSH-71 Remove the impact of the DestructableComponent Interface
    
    https://shibboleth.atlassian.net/browse/JSSH-71
    
    replace doDestroy with annotated method
---
 shib-profile-impl/pom.xml                                          | 5 +++++
 .../impl/DefaultRelyingPartyConfigurationResolver.java             | 7 ++++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/shib-profile-impl/pom.xml b/shib-profile-impl/pom.xml
index cc43aab..5d5e238 100644
--- a/shib-profile-impl/pom.xml
+++ b/shib-profile-impl/pom.xml
@@ -79,6 +79,11 @@
         </dependency>
         
         <!-- Provided Dependencies -->
+        <dependency>
+            <groupId>jakarta.annotation</groupId>
+            <artifactId>jakarta.annotation-api</artifactId>
+            <scope>provided</scope>
+        </dependency>
 
         <!-- Runtime Dependencies -->
 
diff --git a/shib-profile-impl/src/main/java/net/shibboleth/profile/relyingparty/impl/DefaultRelyingPartyConfigurationResolver.java b/shib-profile-impl/src/main/java/net/shibboleth/profile/relyingparty/impl/DefaultRelyingPartyConfigurationResolver.java
index f11b17c..1969aaa 100644
--- a/shib-profile-impl/src/main/java/net/shibboleth/profile/relyingparty/impl/DefaultRelyingPartyConfigurationResolver.java
+++ b/shib-profile-impl/src/main/java/net/shibboleth/profile/relyingparty/impl/DefaultRelyingPartyConfigurationResolver.java
@@ -24,6 +24,8 @@ import java.util.stream.Collectors;
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
+import jakarta.annotation.PreDestroy;
+
 import org.opensaml.core.criterion.EntityIdCriterion;
 import org.opensaml.core.metrics.MetricsSupport;
 import org.opensaml.profile.context.ProfileRequestContext;
@@ -247,14 +249,13 @@ public class DefaultRelyingPartyConfigurationResolver extends AbstractIdentifiab
         }
     }
     
-    /** {@inheritDoc} */
-    @Override protected void doDestroy() {
+    /** Bean-specific function to handle tear down. */
+    @PreDestroy synchronized public void teardown() {
         final String localMetricName = getMetricName();
         if (localMetricName != null && counterGauge != null) {
             MetricsSupport.remove(localMetricName, counterGauge);
         }
         
-        super.doDestroy();
     }
 
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list