[java-shib-shared] 01/01: JSSH-71 Remove the impact of the DestructableComponent Interface

Codeberg noreply at shibboleth.net
Thu May 21 12:33:45 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch dev/JSSH-71
in repository java-shib-shared.

View the commit online:
https://codeberg.org/Shibboleth/java-shib-shared/commit/df135865ef3d935286cd995b1d7ae504966a47ce

commit df135865ef3d935286cd995b1d7ae504966a47ce
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu May 21 13:25:18 2026 +0100

    JSSH-71 Remove the impact of the DestructableComponent Interface
    
    https://shibboleth.atlassian.net/browse/JSSH-71
    
    Remove tests on destroyed-state of a component.
---
 .../shared/component/AbstractInitializableComponent.java   | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/shib-support/src/main/java/net/shibboleth/shared/component/AbstractInitializableComponent.java b/shib-support/src/main/java/net/shibboleth/shared/component/AbstractInitializableComponent.java
index aeb9aef9..a82f011a 100644
--- a/shib-support/src/main/java/net/shibboleth/shared/component/AbstractInitializableComponent.java
+++ b/shib-support/src/main/java/net/shibboleth/shared/component/AbstractInitializableComponent.java
@@ -54,7 +54,7 @@ public abstract class AbstractInitializableComponent implements DestructableComp
     /** {@inheritDoc} */
     @Override
     public final synchronized void initialize() throws ComponentInitializationException {
-        ifDestroyedThrowDestroyedComponentException();
+//        ifDestroyedThrowDestroyedComponentException();
         if (isInitialized()) {
             return;
         }
@@ -63,16 +63,6 @@ public abstract class AbstractInitializableComponent implements DestructableComp
         isInitialized = true;
     }
     
-    /**
-     * Checks if the component is destroyed and, if so, throws a {@link DestroyedComponentException}.
-     */
-    protected void ifDestroyedThrowDestroyedComponentException() {
-        if (isDestroyed()) {
-            throw new DestroyedComponentException(
-                    "Unidentified Component has already been destroyed and can no longer be used.");
-        }
-    }
-
     /**
      * Checks if a component has not been initialized and, if so, throws a {@link UninitializedComponentException}.
      */
@@ -97,7 +87,6 @@ public abstract class AbstractInitializableComponent implements DestructableComp
      * Helper for a setter method to check the standard preconditions.
      */
     protected final void checkSetterPreconditions() {
-        ifDestroyedThrowDestroyedComponentException();
         ifInitializedThrowUnmodifiabledComponentException();
     }
 
@@ -106,7 +95,6 @@ public abstract class AbstractInitializableComponent implements DestructableComp
      * not initialized, or have been destroyed.
      */
     protected final void checkComponentActive() {
-        ifDestroyedThrowDestroyedComponentException();
         ifNotInitializedThrowUninitializedComponentException();
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list