[java-idp-integration-tests] 05/06: Remove need for ambiguous path support in Servlet container

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-idp-integration-tests.

View the commit online:
https://codeberg.org/Shibboleth/java-idp-integration-tests/commit/6629a6d5d71c33d3038b0724c6d58447faa47cb8

commit 6629a6d5d71c33d3038b0724c6d58447faa47cb8
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Sun May 10 20:09:43 2026 -0500

    Remove need for ambiguous path support in Servlet container
    
    Use query params instead of path elements when creating storage records
    in the testbed storage service
---
 .../tests/consent/BasePostgresConsentTest.java        | 19 -------------------
 .../tests/util/TestbedStorageServiceClient.java       |  8 +++++---
 2 files changed, 5 insertions(+), 22 deletions(-)

diff --git a/src/test/java/net/shibboleth/idp/integration/tests/consent/BasePostgresConsentTest.java b/src/test/java/net/shibboleth/idp/integration/tests/consent/BasePostgresConsentTest.java
index f90492e..174449e 100644
--- a/src/test/java/net/shibboleth/idp/integration/tests/consent/BasePostgresConsentTest.java
+++ b/src/test/java/net/shibboleth/idp/integration/tests/consent/BasePostgresConsentTest.java
@@ -110,8 +110,6 @@ public abstract class BasePostgresConsentTest extends AbstractSAML2IntegrationTe
 
         replaceIdPProperty("idp.consent.StorageService", "my.JDBCStorageService");
 
-        enableAmbiguousPathSeparator();
-
         // server.getAdditionalCommands().add("-Didp.loglevel.spring=DEBUG");
     }
 
@@ -185,23 +183,6 @@ public abstract class BasePostgresConsentTest extends AbstractSAML2IntegrationTe
         }
     }
 
-    /**
-     * Enable ambiguous path separator in Jetty for testbed storage service client.
-     * 
-     * @throws IOException
-     *             of an error occurs
-     */
-    public void enableAmbiguousPathSeparator() throws IOException {
-        if (Boolean.getBoolean("tomcat")) {
-            final Path pathToServerXML = pathToTomcatBase.resolve(Paths.get("conf", "server.xml"));
-            replaceFile(pathToServerXML, "secure=\"true\">", "secure=\"true\" encodedSolidusHandling=\"decode\">");
-        } else {
-            final Path idpIni = pathToJettyBase.resolve(Paths.get("start.d", "shibboleth.ini"));
-            replaceFile(idpIni, "\\z",
-                    System.lineSeparator() + "jetty.httpConfig.uriCompliance=DEFAULT,AMBIGUOUS_PATH_SEPARATOR");
-        }
-    }
-
     /**
      * Log in to local dynamic SP with given id.
      * 
diff --git a/src/test/java/net/shibboleth/idp/integration/tests/util/TestbedStorageServiceClient.java b/src/test/java/net/shibboleth/idp/integration/tests/util/TestbedStorageServiceClient.java
index 3de24dd..d575291 100644
--- a/src/test/java/net/shibboleth/idp/integration/tests/util/TestbedStorageServiceClient.java
+++ b/src/test/java/net/shibboleth/idp/integration/tests/util/TestbedStorageServiceClient.java
@@ -84,9 +84,11 @@ public class TestbedStorageServiceClient {
             final String encodedValue = UriUtils.encode(value, "UTF-8");
 
             final String url = baseUrl + //
-                    "/idp/storage/create/" + //
-                    String.join("/", encodedStorageServiceId, encodedContext, encodedKey) + //
-                    "?value=" + encodedValue;
+                    "/idp/storage/create" + //
+                    "?storageServiceId=" + encodedStorageServiceId + //
+                    "&context=" + encodedContext + //
+                    "&key=" + encodedKey + //
+                    "&value=" + encodedValue;
 
             log.debug("Create URL '{}'", url);
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.