[java-oidc-common] 01/02: JCOMOIDC-164 - Rename shouldValidateAcrValue to isValidateAcrValue

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
https://codeberg.org/Shibboleth/java-oidc-common/commit/0af613004db7fa31b84b9fc9e96db07a04c4be2e

commit 0af613004db7fa31b84b9fc9e96db07a04c4be2e
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Apr 30 17:18:32 2026 +0100

    JCOMOIDC-164 - Rename shouldValidateAcrValue to isValidateAcrValue
    
     - renamed
    
    https://shibboleth.atlassian.net/browse/JCOMOIDC-164
---
 .../profile/config/OIDCSSORelyingPartyConfiguration.java |  4 ++--
 .../config/impl/AbstractOIDCSSOConfiguration.java        | 16 ++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCSSORelyingPartyConfiguration.java b/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCSSORelyingPartyConfiguration.java
index d386a62a..3889f4b2 100644
--- a/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCSSORelyingPartyConfiguration.java
+++ b/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCSSORelyingPartyConfiguration.java
@@ -90,8 +90,8 @@ public interface OIDCSSORelyingPartyConfiguration extends OAuth2TokenEncryptionP
      * 
      * @since 3.4.0
      */
-    @ConfigurationSetting(name="shouldValidateAcrValue")
-    default boolean shouldValidateAcrValue(@Nullable final ProfileRequestContext profileRequestContext) {
+    @ConfigurationSetting(name="validateAcrValue")
+    default boolean isValidateAcrValue(@Nullable final ProfileRequestContext profileRequestContext) {
         // Evaluate the claims as a default
         return true;
     }
diff --git a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/AbstractOIDCSSOConfiguration.java b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/AbstractOIDCSSOConfiguration.java
index c7a4ea0e..0e060223 100644
--- a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/AbstractOIDCSSOConfiguration.java
+++ b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/AbstractOIDCSSOConfiguration.java
@@ -120,7 +120,7 @@ public abstract class AbstractOIDCSSOConfiguration extends AbstractOAuth2FlowAwa
      * A predicate to determine if the ACR value in an id_token should be validated against those in the request. 
      * Defaults to true.
      */
-    @Nonnull private Predicate<ProfileRequestContext> shouldValidateAcrValue;
+    @Nonnull private Predicate<ProfileRequestContext> validateAcrValue;
     
     /** Whether to perform standard response data extraction. */
     @Nonnull private Predicate<ProfileRequestContext> extractStandardAttributesPredicate;
@@ -158,7 +158,7 @@ public abstract class AbstractOIDCSSOConfiguration extends AbstractOAuth2FlowAwa
         strictScopeValidationPredicate = PredicateSupport.alwaysFalse();        
         attributeResolutionPrincipalLookupStrategy = FunctionSupport.constant(null);
         attributeExtractionStrategyLookupStrategy = FunctionSupport.constant(null);
-        shouldValidateAcrValue = PredicateSupport.alwaysTrue();
+        validateAcrValue = PredicateSupport.alwaysTrue();
         extractStandardAttributesPredicate = PredicateSupport.alwaysTrue();
     }
     
@@ -786,8 +786,8 @@ public abstract class AbstractOIDCSSOConfiguration extends AbstractOAuth2FlowAwa
 
     /** {@inheritDoc} */
     @Override
-    public boolean shouldValidateAcrValue(@Nullable final ProfileRequestContext profileRequestContext) {
-        return shouldValidateAcrValue.test(profileRequestContext);
+    public boolean isValidateAcrValue(@Nullable final ProfileRequestContext profileRequestContext) {
+        return validateAcrValue.test(profileRequestContext);
     }
     
     /**
@@ -797,8 +797,8 @@ public abstract class AbstractOIDCSSOConfiguration extends AbstractOAuth2FlowAwa
      *  
      * @since 3.4.0
      */
-    public void setShouldValidateAcrValuePredicate(@Nonnull final Predicate<ProfileRequestContext> predicate) {
-        shouldValidateAcrValue = Constraint.isNotNull(predicate,
+    public void setValidateAcrValuePredicate(@Nonnull final Predicate<ProfileRequestContext> predicate) {
+        validateAcrValue = Constraint.isNotNull(predicate,
                 "Should validate ACR value predicate can not be null");
     }
     /**
@@ -808,8 +808,8 @@ public abstract class AbstractOIDCSSOConfiguration extends AbstractOAuth2FlowAwa
      * 
      * @since 3.4.0
      */
-    public void setShouldValidateAcrValue(final boolean flag) {
-        shouldValidateAcrValue = flag ? PredicateSupport.alwaysTrue() : PredicateSupport.alwaysFalse();
+    public void setValidateAcrValue(final boolean flag) {
+        validateAcrValue = flag ? PredicateSupport.alwaysTrue() : PredicateSupport.alwaysFalse();
     }
     
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.