[java-plugin-shibd-oidc] branch main updated: Remove commented out provider metadata lookup

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd-oidc.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-oidc/commit/0124cc6c08102b529b37cc747af76571b96ddcc8

The following commit(s) were added to refs/heads/main by this push:
     new 0124cc6  Remove commented out provider metadata lookup
0124cc6 is described below

commit 0124cc6c08102b529b37cc747af76571b96ddcc8
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Mar 12 09:37:55 2026 +0000

    Remove commented out provider metadata lookup
    
            - Metadata is already looked up at the begining of the flow. This is
    cleaner than the RP-Proxy and so I removed this.
---
 .../net/shibboleth/idp/flows/sp/consumer/oidc/oidc-beans.xml   | 10 +++-------
 .../META-INF/net/shibboleth/idp/flows/sp/oidc-common-beans.xml |  2 +-
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/oidc/oidc-beans.xml b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/oidc/oidc-beans.xml
index c3a7165..f91363f 100644
--- a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/oidc/oidc-beans.xml
+++ b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/oidc/oidc-beans.xml
@@ -489,12 +489,7 @@
                                     </constructor-arg>
                                 </bean>
                             </property>                            
-                        </bean>  
-                        
-                       <!--  <bean
-                            class="net.shibboleth.idp.plugin.authn.oidc.rp.metadata.impl.OIDCProviderMetadataLookupHandler"
-                            scope="prototype" p:copyContextStrategy-ref="shibboleth.ChildLookup.OutboundOIDCMetadataContextLookup"
-                            p:providerMetadataResolver-ref="shibboleth.authn.oidc.rp.ProviderMetadataResolver" />     -->                        
+                        </bean>                      
                             
                         <bean class="net.shibboleth.oidc.security.impl.JWTMessageSignatureSecurityHandler"
                             scope="prototype">
@@ -508,7 +503,8 @@
                             <property name="providerMetadataLookupStrategy">
                                 <ref bean="shibboleth.ChildLookup.OIDCProviderMetadataFromPeerEntityContext" />
                             </property>
-                        </bean>                        
+                        </bean>       
+                                         
                     </list>
                 </property>
             </bean>
diff --git a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/oidc-common-beans.xml b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/oidc-common-beans.xml
index be352f4..6bcbd1f 100644
--- a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/oidc-common-beans.xml
+++ b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/oidc-common-beans.xml
@@ -190,7 +190,7 @@
     <!-- Common Actions -->
     
     <bean id="ProviderMetadataLookup" parent="WebFlowInboundMessageHandlerAdaptor" scope="prototype">
-        <constructor-arg name="messageHandler"> <!-- TODO move into common beans? -->
+        <constructor-arg name="messageHandler">
             <bean class="net.shibboleth.sp.oidc.metadata.impl.OIDCProviderMetadataLookupHandler"
                 scope="prototype">
                 <property name="ProviderMetadataResolverLookupStrategy">

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.