[java-plugin-shibd] branch main updated: JSHIBD-22 - Optimize remote URL transport

Codeberg noreply at shibboleth.net
Tue Jun 30 16:03:15 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd/commit/af3ac46ea21b2f1a2c25238895fca0760baf9d4c

The following commit(s) were added to refs/heads/main by this push:
     new af3ac46  JSHIBD-22 - Optimize remote URL transport
af3ac46 is described below

commit af3ac46ea21b2f1a2c25238895fca0760baf9d4c
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Tue Jun 30 12:03:03 2026 -0400

    JSHIBD-22 - Optimize remote URL transport
    
    https://shibboleth.atlassian.net/browse/JSHIBD-22
    
    Remove allowance for pre-alpha2 behavior.
---
 .../shibboleth/sp/messaging/RemotedHttpServletRequest.java | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/sp-server-api/src/main/java/net/shibboleth/sp/messaging/RemotedHttpServletRequest.java b/sp-server-api/src/main/java/net/shibboleth/sp/messaging/RemotedHttpServletRequest.java
index cce6241..1f81bfe 100644
--- a/sp-server-api/src/main/java/net/shibboleth/sp/messaging/RemotedHttpServletRequest.java
+++ b/sp-server-api/src/main/java/net/shibboleth/sp/messaging/RemotedHttpServletRequest.java
@@ -588,7 +588,8 @@ public class RemotedHttpServletRequest implements HttpServletRequest {
             return uri.string();
         } else if (uri.isunsafestring()) {
             // The "uri" used to contain the query string but is not intended to post-alpha2.
-            return decodeUnsafeString(uri.unsafe_string(), decoder, '?');
+            // We no longer check for that case.
+            return decodeUnsafeString(uri.unsafe_string(), decoder, null);
         } else {
             return null;
         }
@@ -714,12 +715,13 @@ public class RemotedHttpServletRequest implements HttpServletRequest {
 
         try {
             final String decoded = decoder.decode(wrapper).toString();
-            final int index = delim != null ? decoded.indexOf(delim) : 0;
-            if (index > 0) {
-                return decoded.substring(0, index);
-            } else {
-                return decoded;
+            if (delim != null) {
+                final int index = decoded.indexOf(delim);
+                if (index > 0) {
+                    return decoded.substring(0, index);
+                }
             }
+            return decoded;
         } catch (final CharacterCodingException e) {
 
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list