[java-plugin-shibd-saml] branch main updated: Add null checking to Agent-supplied endpoint list.
Codeberg
noreply at shibboleth.net
Mon Jun 29 13:47:22 UTC 2026
This is an automated email from the git hooks/post-receive script.
codeberg pushed a commit to branch main
in repository java-plugin-shibd-saml.
View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-saml/commit/ae1af8272568183798765cd14ffc3b36f36bc261
The following commit(s) were added to refs/heads/main by this push:
new ae1af82 Add null checking to Agent-supplied endpoint list.
ae1af82 is described below
commit ae1af8272568183798765cd14ffc3b36f36bc261
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Mon Jun 29 09:47:04 2026 -0400
Add null checking to Agent-supplied endpoint list.
---
.../shibboleth/sp/saml/flows/saml2/SAML2SessionInitiatorFlowTest.java | 1 +
.../java/net/shibboleth/sp/saml/saml2/profile/impl/AddAuthnRequest.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/sp-saml-conf-impl/src/test/java/net/shibboleth/sp/saml/flows/saml2/SAML2SessionInitiatorFlowTest.java b/sp-saml-conf-impl/src/test/java/net/shibboleth/sp/saml/flows/saml2/SAML2SessionInitiatorFlowTest.java
index ad1de05..d2521aa 100644
--- a/sp-saml-conf-impl/src/test/java/net/shibboleth/sp/saml/flows/saml2/SAML2SessionInitiatorFlowTest.java
+++ b/sp-saml-conf-impl/src/test/java/net/shibboleth/sp/saml/flows/saml2/SAML2SessionInitiatorFlowTest.java
@@ -241,6 +241,7 @@ public class SAML2SessionInitiatorFlowTest extends AbstractSPFlowTest {
input.addmember(SPConstants.TARGET).unsafe_string(RESOURCE_URL);
final DDF endpoints = input.addmember(InitiatorConstants.RESPONSE_URL).list();
endpoints.add(new DDF("POST").string(POST_RESPONSE_URL));
+ endpoints.add(new DDF(null).string("bogus"));
endpoints.add(new DDF("Artifact").string(ARTIFACT_RESPONSE_URL));
setApplicationRequest("response-binding", input);
diff --git a/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/AddAuthnRequest.java b/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/AddAuthnRequest.java
index ee666ba..7da0a00 100644
--- a/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/AddAuthnRequest.java
+++ b/sp-saml-impl/src/main/java/net/shibboleth/sp/saml/saml2/profile/impl/AddAuthnRequest.java
@@ -416,7 +416,7 @@ public class AddAuthnRequest extends AbstractApplicationAction {
// need to locate a match using the binding map. This is essentially the legacy case
// for preserving support for per-binding endpoints from the older SP.
final Optional<DDF> match = endpoints.stream()
- .filter(e -> { return binding.equals(inboundBindingMap.get(e.name())); })
+ .filter(e -> { return e != null && e.name() != null && binding.equals(inboundBindingMap.get(e.name())); })
.findFirst();
if (match.isPresent()) {
authnRequest.setAssertionConsumerServiceURL(match.get().string());
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list