[cpp-sp] branch main updated: Remove extra parameter for API call.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/508b22bdc5e5ab4ab2e61f3dad305ce2394d869d

The following commit(s) were added to refs/heads/main by this push:
     new 508b22bd Remove extra parameter for API call.
508b22bd is described below

commit 508b22bdc5e5ab4ab2e61f3dad305ce2394d869d
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Thu Jun 4 11:50:54 2026 -0400

    Remove extra parameter for API call.
---
 shibsp/AbstractSPRequest.cpp          | 2 +-
 shibsp/AbstractSPRequest.h            | 2 +-
 shibsp/SPRequest.h                    | 7 +++----
 shibsp/handler/impl/LogoutHandler.cpp | 2 +-
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/shibsp/AbstractSPRequest.cpp b/shibsp/AbstractSPRequest.cpp
index 18b588f9..4a564ab0 100644
--- a/shibsp/AbstractSPRequest.cpp
+++ b/shibsp/AbstractSPRequest.cpp
@@ -273,7 +273,7 @@ const char* AbstractSPRequest::getHandlerURL(const char* resource) const
     return m_handlerURL.c_str();
 }
 
-string AbstractSPRequest::getNotificationURL(bool front, unsigned int index) const
+string AbstractSPRequest::getNotificationURL(unsigned int index) const
 {
     // We have to process the underlying setting each call to this method for now.
     // Given how rarely it would be used, not a big issue.
diff --git a/shibsp/AbstractSPRequest.h b/shibsp/AbstractSPRequest.h
index 8580ad66..cd67b2af 100644
--- a/shibsp/AbstractSPRequest.h
+++ b/shibsp/AbstractSPRequest.h
@@ -73,7 +73,7 @@ namespace shibsp {
         std::vector<const char*>::size_type getParameters(const char* name, std::vector<const char*>& values) const;
         const std::map<std::string,std::string>& getCookies() const;
         const char* getHandlerURL(const char* resource=nullptr) const;
-        std::string getNotificationURL(bool front, unsigned int index) const;
+        std::string getNotificationURL(unsigned int index) const;
         void limitRedirect(const char* url) const;
 
         std::string getSecureHeader(const char* name) const;
diff --git a/shibsp/SPRequest.h b/shibsp/SPRequest.h
index 1f45c41c..8b8f6980 100644
--- a/shibsp/SPRequest.h
+++ b/shibsp/SPRequest.h
@@ -111,13 +111,12 @@ namespace shibsp {
         virtual const char* getHandlerURL(const char* resource=nullptr) const=0;
 
         /**
-         * Returns the designated notification URL, or an empty string if no more locations are specified.
+         * Returns the "next" notification URL, or an empty string if no more locations are specified.
          *
-         * @param front     true iff front channel notification is desired, false iff back channel is desired
-         * @param index     zero-based index of URL to return
+         * @param index zero-based index of URL to return
          * @return  the designated URL, or an empty string
          */
-        virtual std::string getNotificationURL(bool front, unsigned int index) const=0;
+        virtual std::string getNotificationURL(unsigned int index) const=0;
 
         /**
          * Checks a proposed redirect URL against policy settings for legal redirects,
diff --git a/shibsp/handler/impl/LogoutHandler.cpp b/shibsp/handler/impl/LogoutHandler.cpp
index 1d0e3016..8d4589d5 100644
--- a/shibsp/handler/impl/LogoutHandler.cpp
+++ b/shibsp/handler/impl/LogoutHandler.cpp
@@ -56,7 +56,7 @@ pair<bool,long> LogoutHandler::notifyFrontChannel(SPRequest& request, bool conti
     param = request.getParameter("return");
 
     // Fetch the next front notification URL and bump the index for the next round trip.
-    string loc = request.getNotificationURL(true, index++);
+    string loc = request.getNotificationURL(index++);
     if (loc.empty()) {
         return make_pair(false,0L);
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.