[java-plugin-shibd-oidc] branch dev/JSHIBDOIDC-31-cred-resolver updated: Javadoc updates with TODO reminder.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch dev/JSHIBDOIDC-31-cred-resolver
in repository java-plugin-shibd-oidc.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-oidc/commit/8c9fa5fa7f4b4880f86d599e685353c1038e42d2

The following commit(s) were added to refs/heads/dev/JSHIBDOIDC-31-cred-resolver by this push:
     new 8c9fa5f  Javadoc updates with TODO reminder.
8c9fa5f is described below

commit 8c9fa5fa7f4b4880f86d599e685353c1038e42d2
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Jul 29 18:27:13 2026 +0100

    Javadoc updates with TODO reminder.
---
 .../META-INF/net/shibboleth/sp/service/agent/postconfig.xml        | 4 ++--
 .../sp/jose/config/impl/BasicSignatureSigningConfiguration.java    | 7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/sp/service/agent/postconfig.xml b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/sp/service/agent/postconfig.xml
index 7878a00..6f71b8b 100644
--- a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/sp/service/agent/postconfig.xml
+++ b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/sp/service/agent/postconfig.xml
@@ -301,8 +301,8 @@
         <constructor-arg>
             <list>
                 <bean class="net.shibboleth.oidc.security.credential.impl.LocalJOSEObjectCredentialResolver">
-                    <constructor-arg name="localCredentialResolver">
-                        <bean
+                    <constructor-arg name="localCredentialResolver"><!-- TODO change to the shibboleth.sp.CredentialResolverBridge -->
+                        <bean 
                             class="net.shibboleth.oidc.security.credential.impl.CollectionJOSEObjectCredentialResolver"
                             c:credentials-ref="shibboleth.oidc.EncryptionCredentials" />
                     </constructor-arg>
diff --git a/sp-oidc-impl/src/main/java/net/shibboleth/sp/jose/config/impl/BasicSignatureSigningConfiguration.java b/sp-oidc-impl/src/main/java/net/shibboleth/sp/jose/config/impl/BasicSignatureSigningConfiguration.java
index 0389a7d..c7448b4 100644
--- a/sp-oidc-impl/src/main/java/net/shibboleth/sp/jose/config/impl/BasicSignatureSigningConfiguration.java
+++ b/sp-oidc-impl/src/main/java/net/shibboleth/sp/jose/config/impl/BasicSignatureSigningConfiguration.java
@@ -37,10 +37,12 @@ import net.shibboleth.shared.resolver.CriteriaSet;
 import net.shibboleth.shared.resolver.ResolverException;
 
 /**
- * Subclass of OpenSAML version to provide support for CredentialResolver service
+ * Subclass of the JOSE version to provide support for CredentialResolver service
  * through a bridging class.
  * 
- * <p>This class currently assumes SAML protocol usage when resolving credentials.</p>
+ * <p>This class currently assumes OIDC protocol usage when resolving credentials.</p>
+ * 
+ * TODO: given the changes in oidc-commons, we could add something appropriate there. 
  */
 public class BasicSignatureSigningConfiguration 
 	extends net.shibboleth.oidc.security.jose.impl.BasicSignatureSigningConfiguration {
@@ -71,7 +73,6 @@ public class BasicSignatureSigningConfiguration
         
         // Resolve if possible using: TODO
         //  * UsageType = SIGNING
-        //  * Class = X509Credential
         //  * Protocol = if set
         
         final CriteriaSet criteria = new CriteriaSet(new UsageCriterion(UsageType.SIGNING),

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.