[java-opensaml] branch main updated: OSJ-450 - Review usage of SecurityConfiguration getClockSkew method

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-opensaml.

View the commit online:
https://codeberg.org/Shibboleth/java-opensaml/commit/506f4846c12e1eb23e501a8ec7fb22eae64e139c

The following commit(s) were added to refs/heads/main by this push:
     new 506f4846c OSJ-450 - Review usage of SecurityConfiguration getClockSkew method
506f4846c is described below

commit 506f4846c12e1eb23e501a8ec7fb22eae64e139c
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Wed Jul 22 09:58:08 2026 -0400

    OSJ-450 - Review usage of SecurityConfiguration getClockSkew method
    
    https://shibboleth.atlassian.net/browse/OSJ-450
    
    Deprecate clockSkew property for now with getter warning.
---
 .../security/config/BasicSecurityConfiguration.java   | 19 +++++++++++++++++--
 .../security/config/SecurityConfiguration.java        |  3 +++
 .../xmlsec/config/BasicXMLSecurityConfiguration.java  | 10 ++++++++++
 3 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/config/BasicSecurityConfiguration.java b/opensaml-security-api/src/main/java/org/opensaml/security/config/BasicSecurityConfiguration.java
index e711d218a..f597353ee 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/config/BasicSecurityConfiguration.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/config/BasicSecurityConfiguration.java
@@ -21,6 +21,8 @@ import javax.annotation.Nullable;
 
 import net.shibboleth.shared.component.IdentifiableComponent;
 import net.shibboleth.shared.logic.Constraint;
+import net.shibboleth.shared.primitive.DeprecationSupport;
+import net.shibboleth.shared.primitive.DeprecationSupport.ObjectType;
 import net.shibboleth.shared.security.IdentifierGenerationStrategy;
 import net.shibboleth.shared.security.IdentifierGenerationStrategy.ProviderType;
 
@@ -55,16 +57,27 @@ public class BasicSecurityConfiguration implements SecurityConfiguration, Identi
      * Initializes the clock skew to 5 minutes and the identifier generator to {@link ProviderType#SECURE}.
      */
     public BasicSecurityConfiguration() {
-        clockSkew = Duration.ofMinutes(5);
-        idGenerator = IdentifierGenerationStrategy.getInstance(ProviderType.SECURE);
+        this(Duration.ofMinutes(5), IdentifierGenerationStrategy.getInstance(ProviderType.SECURE));
     }
 
+    /**
+     * Constructor.
+     * 
+     * @param generator the identifier generator, must not be null
+     */
+    public BasicSecurityConfiguration(@Nonnull final IdentifierGenerationStrategy generator) {
+        this(Duration.ofMinutes(5), generator);
+    }
+    
     /**
      * Constructor.
      * 
      * @param skew the clock skew, must be greater than 0
      * @param generator the identifier generator, must not be null
+     * 
+     * @deprecated
      */
+    @Deprecated(since="5.3.0", forRemoval=true)
     public BasicSecurityConfiguration(@Nonnull final Duration skew,
             @Nonnull final IdentifierGenerationStrategy generator) {
         Constraint.isNotNull(skew, "Clock skew cannot be null");
@@ -85,7 +98,9 @@ public class BasicSecurityConfiguration implements SecurityConfiguration, Identi
     }
     
     /** {@inheritDoc} */
+    @Deprecated(since="5.3.0", forRemoval=true)
     @Nonnull public Duration getClockSkew() {
+        DeprecationSupport.warn(ObjectType.METHOD, "getClockSkew", "SecurityConfiguration", null);
         return clockSkew;
     }
 
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/config/SecurityConfiguration.java b/opensaml-security-api/src/main/java/org/opensaml/security/config/SecurityConfiguration.java
index ac375e070..91c3f65e4 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/config/SecurityConfiguration.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/config/SecurityConfiguration.java
@@ -35,7 +35,10 @@ public interface SecurityConfiguration {
      * Get the acceptable clock skew.
      * 
      * @return acceptable clock skew
+     * 
+     * @deprecated
      */
+    @Deprecated(since="5.3.0", forRemoval=true)
     @Nonnull Duration getClockSkew();
 
     /**
diff --git a/opensaml-xmlsec-api/src/main/java/org/opensaml/xmlsec/config/BasicXMLSecurityConfiguration.java b/opensaml-xmlsec-api/src/main/java/org/opensaml/xmlsec/config/BasicXMLSecurityConfiguration.java
index 77be1166d..3db7bf196 100644
--- a/opensaml-xmlsec-api/src/main/java/org/opensaml/xmlsec/config/BasicXMLSecurityConfiguration.java
+++ b/opensaml-xmlsec-api/src/main/java/org/opensaml/xmlsec/config/BasicXMLSecurityConfiguration.java
@@ -53,12 +53,22 @@ public class BasicXMLSecurityConfiguration extends BasicSecurityConfiguration im
         
     }
 
+    /**
+     * Constructor.
+     * 
+     * @param generator the identifier generator, must not be null
+     */
+    public BasicXMLSecurityConfiguration(@Nonnull final IdentifierGenerationStrategy generator) {
+        super(generator);
+    }
+    
     /**
      * Constructor.
      * 
      * @param skew the clock skew, must be greater than 0
      * @param generator the identifier generator, must not be null
      */
+    @Deprecated(since="5.3.0", forRemoval=true)
     public BasicXMLSecurityConfiguration(@Nonnull final Duration skew,
             @Nonnull final IdentifierGenerationStrategy generator) {
         super(skew, generator);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.