[java-shib-attribute] branch main updated: JSSH-71 Remove the impact of the DestructableComponent Interface

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
https://codeberg.org/Shibboleth/java-shib-attribute/commit/31e86474c027ae04fe32f8655c11866e6d3e8aa1

The following commit(s) were added to refs/heads/main by this push:
     new 31e86474c JSSH-71 Remove the impact of the DestructableComponent Interface
31e86474c is described below

commit 31e86474c027ae04fe32f8655c11866e6d3e8aa1
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sat Jul 18 14:32:39 2026 +0100

    JSSH-71 Remove the impact of the DestructableComponent Interface
    
    https://shibboleth.atlassian.net/browse/JSSH-71
    
    Mitigate against the fact that AbstractResolverPlugin accidentally
    implements DisposableBean
    
    This is done to as to obey all our sematic versioning rules.
---
 .../idp/attribute/resolver/AbstractResolverPlugin.java      | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/shib-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPlugin.java b/shib-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPlugin.java
index bba7018e4..0f860cbc1 100644
--- a/shib-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPlugin.java
+++ b/shib-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractResolverPlugin.java
@@ -213,6 +213,19 @@ public abstract class AbstractResolverPlugin<ResolvedType> extends AbstractIdent
         }
     }
 
+    /** {@inheritDoc}.
+     *
+     *  This is mitigation against the fact that this class accidentally implemnents {@link DisposableBean}
+     *
+     *  We implement {{@link #doDestroy()} but do not call {@link super#doDestroy()} thus avoiding any deprecation
+     *  logging we may chose to add there.  In general this is frowned upon but we know that no "inner" class
+     *  (and indeed none of our "outer" classes do anything in the doDestroy() path.
+     */
+    @Override
+    @Deprecated(forRemoval = true, since = "5.3")
+    protected void doDestroy() {
+    }
+
     /** {@inheritDoc} */
     @Override public int hashCode() {
         return Objects.hash(getId());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.