[java-plugin-shibd-oidc] 04/05: Remove redundant state generation

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd-oidc.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-oidc/commit/803624f4edbc6b16d4999258a2749f231d2b5de5

commit 803624f4edbc6b16d4999258a2749f231d2b5de5
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Jul 14 11:58:53 2026 +0100

    Remove redundant state generation
    
     - Whilst you can carry state between logout request and possible
    post_logout_redirect response, we have no use for it currently. Also,
    the post_logout redirect could be anywhere on the application and not
    something processed by the Hub, and state might not make sense there.
    Finally, post_logout redirects seem fragile or even not visible to the
    user, so we turn those off by default.
---
 .../flows/sp/logout/initiator/oidc/oidc-beans.xml  | 28 ++--------------------
 .../flows/sp/logout/initiator/oidc/oidc-flow.xml   |  2 --
 2 files changed, 2 insertions(+), 28 deletions(-)

diff --git a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-beans.xml b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-beans.xml
index c8638ab..062b0f9 100644
--- a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-beans.xml
+++ b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-beans.xml
@@ -112,32 +112,7 @@
         <property name="errorEvent">
             <util:constant static-field="org.opensaml.profile.action.EventIds.INVALID_MESSAGE" />
         </property>
-    </bean>
-    
-    <!-- 
-        Create the Authentication State Data from the authentication request that is preserved for later recovery
-        in the consumer flow.
-    -->
-    <bean id="CreateLogoutStateData" class="net.shibboleth.sp.oidc.profile.impl.CreateStateData"
-        scope="prototype"
-        p:stateDataContextCreationStrategy-ref="shibboleth.ChildLookupOrCreate.StateDataContext"
-        p:stateDataLookupStrategy-ref="LogoutRequestStateForStorageStrategy"/>
-        
-     <!-- 
-        A strategy for creating Logout Stata Data from the logout request. 
-    -->
-    <bean id="LogoutRequestStateForStorageStrategy" scope="prototype"
-        class="net.shibboleth.sp.oidc.profile.impl.LogoutRequestStateForStorageStrategy" /> 
-    
-    
-     <!-- 
-        Store off the authentication state data in the state data context so it can be recovered later when processing 
-        the response. By default, failure to store off the state will be fatal.
-     -->
-    <bean id="PreserveOAuthState"
-        class="net.shibboleth.sp.oidc.profile.impl.PreserveOAuthState" scope="prototype"
-        p:stateDataContextLookupStrategy-ref="shibboleth.ChildLookup.StateDataContext"
-        p:errorFatal="%{sp.stateToken.errorsFatal:true}" />
+    </bean>  
     
     <bean id="HandleOutboundMessage" class="net.shibboleth.idp.profile.impl.WebFlowMessageHandlerAdaptor"
         scope="prototype" c:messageHandler-ref="PreEncodeMessageHandler" c:executionDirection="OUTBOUND">
@@ -150,6 +125,7 @@
         scope="prototype">
         <property name="handlers">
             <list>
+                <!-- none -->
             </list>
         </property>
     </bean>
diff --git a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-flow.xml b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-flow.xml
index b7a92bd..ec27146 100644
--- a/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-flow.xml
+++ b/sp-oidc-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/oidc/oidc-flow.xml
@@ -17,8 +17,6 @@
         <evaluate expression="InitializeLogoutRequest" />
         
         <evaluate expression="BuildLogoutRequest" />
-        <evaluate expression="CreateLogoutStateData"/> 
-        <evaluate expression="PreserveOAuthState" />
         <evaluate expression="HandleOutboundMessage" />
         <evaluate expression="EncodeMessage" /> 
         <evaluate expression="'proceed'" />

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.