[cpp-sp] branch main updated: CPPSP-42 Logging from Status handler could be more informative.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/007e87457701952f5789ef16697347a53706b53a

The following commit(s) were added to refs/heads/main by this push:
     new 007e8745 CPPSP-42 Logging from Status handler could be more informative.
007e8745 is described below

commit 007e87457701952f5789ef16697347a53706b53a
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri Jan 23 15:48:40 2026 +0000

    CPPSP-42 Logging from Status handler could be more informative.
    
    https://shibboleth.atlassian.net/browse/CPPSP-42
    
    Log all failures from the hub (at debug).
---
 shibsp/remoting/impl/AbstractRemotingService.cpp | 8 +++++++-
 shibsp/remoting/impl/AbstractRemotingService.h   | 3 +++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/shibsp/remoting/impl/AbstractRemotingService.cpp b/shibsp/remoting/impl/AbstractRemotingService.cpp
index ed83d9e8..16128daf 100644
--- a/shibsp/remoting/impl/AbstractRemotingService.cpp
+++ b/shibsp/remoting/impl/AbstractRemotingService.cpp
@@ -50,16 +50,22 @@ DDF AbstractRemotingService::send(const DDF& in, bool checkEvent) const
 
     const char* event = output.getmember("event").string();
     if (event && strcmp(event, "success")) {
+        string message("Send Message Failed: ");
+        message += event;
         OperationException ex("Remote operation was unsuccessful.");
         ex.addProperty(AgentException::EVENT_PROP_NAME, event);
         if (in.name()) {
             ex.addProperty("operation", in.name());
+            message += " operation : ";
+            message += in.name();
         }
         const char* target = output.getmember("target").string();
         if (target) {
             ex.addProperty(AgentException::TARGET_PROP_NAME, target);
+            message += " target : ";
+            message += target;
         }
-
+        logger().debug(message);
         output.destroy();
         throw ex;
     }
diff --git a/shibsp/remoting/impl/AbstractRemotingService.h b/shibsp/remoting/impl/AbstractRemotingService.h
index ea052121..040ffe27 100644
--- a/shibsp/remoting/impl/AbstractRemotingService.h
+++ b/shibsp/remoting/impl/AbstractRemotingService.h
@@ -22,6 +22,7 @@
 #define __shibsp_absremotingservice_h__
 
 #include "remoting/RemotingService.h"
+#include "logging/Category.h"
 
 #include <iostream>
 #include <boost/property_tree/ptree_fwd.hpp>
@@ -44,6 +45,8 @@ namespace shibsp {
          */
         DDF send(const DDF& in, bool checkEvent=true) const;
 
+        virtual Category& logger() const = 0;
+
     protected:
         AbstractRemotingService(const boost::property_tree::ptree& pt);
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.