[java-opensaml] branch main updated: OSJ-438 - NameIDFormat filter won't remove if no formats supplied

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-opensaml.

View the commit online:
https://codeberg.org/Shibboleth/java-opensaml/commit/ffbf8038b9e01d407b7d91cf0ad055a39fe60bd8

The following commit(s) were added to refs/heads/main by this push:
     new ffbf8038b OSJ-438 - NameIDFormat filter won't remove if no formats supplied
ffbf8038b is described below

commit ffbf8038b9e01d407b7d91cf0ad055a39fe60bd8
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Jan 20 14:22:58 2026 -0500

    OSJ-438 - NameIDFormat filter won't remove if no formats supplied
    
    https://shibboleth.atlassian.net/browse/OSJ-438
    
    Eliminate optimization around empty collection as it no longer applies.
---
 .../opensaml/saml/metadata/resolver/filter/impl/NameIDFormatFilter.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/NameIDFormatFilter.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/NameIDFormatFilter.java
index 6706c05ba..c0b3d4fcf 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/NameIDFormatFilter.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/NameIDFormatFilter.java
@@ -135,7 +135,7 @@ public class NameIDFormatFilter extends AbstractMetadataFilter {
      */
     protected void filterEntityDescriptor(@Nonnull final EntityDescriptor descriptor) {
         for (final Map.Entry<Predicate<EntityDescriptor>,Collection<String>> entry : applyMap.asMap().entrySet()) {
-            if ((removeExistingFormats || !entry.getValue().isEmpty()) && entry.getKey().test(descriptor)) {
+            if (entry.getKey().test(descriptor)) {
                 for (final RoleDescriptor role : descriptor.getRoleDescriptors()) {
                     assert role != null;
                     filterRoleDescriptor(role, entry.getValue());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.