[cpp-sp] 01/02: Fix input structure creation for operations.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/991feb8e9397888de8b6f52d09e1bba07d2e882b

commit 991feb8e9397888de8b6f52d09e1bba07d2e882b
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Jan 13 13:05:27 2026 -0500

    Fix input structure creation for operations.
---
 shibsp/session/impl/StorageServiceSessionCache.cpp | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/shibsp/session/impl/StorageServiceSessionCache.cpp b/shibsp/session/impl/StorageServiceSessionCache.cpp
index dc84ea3b..c8da4a47 100644
--- a/shibsp/session/impl/StorageServiceSessionCache.cpp
+++ b/shibsp/session/impl/StorageServiceSessionCache.cpp
@@ -95,7 +95,7 @@ StorageServiceSessionCache::~StorageServiceSessionCache()
 
 string StorageServiceSessionCache::cache_create(SPRequest* request, DDF& sessionData)
 {
-    DDF in("session-cache");
+    DDF in = DDF("session-cache").structure();
     DDFJanitor injanitor(in);
     DDF sessionCopy = sessionData.copy();
     in.add(sessionCopy.name("session"));
@@ -129,7 +129,7 @@ DDF StorageServiceSessionCache::cache_read(
     const char* client_addr
     )
 {
-    DDF in("session-cache");
+    DDF in = DDF("session-cache").structure();
     DDFJanitor injanitor(in);
 
     in.addmember("op").string("R");
@@ -232,14 +232,13 @@ DDF StorageServiceSessionCache::cache_read(
         }
     }    
 
-    // Otherwise return the detached session structure after re-installing the key into the root name.
-    sessionData.name(key);
+    // Otherwise return the detached session structure.
     return sessionData.remove();
 }
 
 bool StorageServiceSessionCache::cache_update(SPRequest* request, const char* key, unsigned int version, DDF& sessionData)
 {
-    DDF in("session-cache");
+    DDF in = DDF("session-cache").structure();
     DDFJanitor injanitor(in);
 
     DDF sessionCopy = sessionData.copy();
@@ -287,7 +286,7 @@ bool StorageServiceSessionCache::cache_update(SPRequest* request, const char* ke
 
 bool StorageServiceSessionCache::cache_touch(SPRequest* request, const char* key, unsigned int version, unsigned int timeout)
 {
-    DDF in("session-cache");
+    DDF in = DDF("session-cache").structure();
     DDFJanitor injanitor(in);
     in.addmember("op").string("T");
     in.addmember("key").string(key);
@@ -337,7 +336,7 @@ bool StorageServiceSessionCache::cache_touch(SPRequest* request, const char* key
 
 void StorageServiceSessionCache::cache_remove(SPRequest* request, const char* key)
 {
-    DDF in("session-cache");
+    DDF in = DDF("session-cache").structure();
     DDFJanitor injanitor(in);
 
     in.addmember("op").string("D");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.