[java-plugin-shibd-oidc] branch main updated: Fix cookie name in tests

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd-oidc.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-oidc/commit/a2f663070a8cc2b45f03ca325e74f43b17bd9726

The following commit(s) were added to refs/heads/main by this push:
     new a2f6630  Fix cookie name in tests
a2f6630 is described below

commit a2f663070a8cc2b45f03ca325e74f43b17bd9726
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Feb 20 17:06:48 2026 +0000

    Fix cookie name in tests
---
 .../src/test/java/net/shibboleth/sp/oidc/flows/TestConstants.java   | 4 ++--
 .../net/shibboleth/idp/module/conf/sp/oidc-test.properties          | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/sp-oidc-conf-impl/src/test/java/net/shibboleth/sp/oidc/flows/TestConstants.java b/sp-oidc-conf-impl/src/test/java/net/shibboleth/sp/oidc/flows/TestConstants.java
index 27106c3..b581746 100644
--- a/sp-oidc-conf-impl/src/test/java/net/shibboleth/sp/oidc/flows/TestConstants.java
+++ b/sp-oidc-conf-impl/src/test/java/net/shibboleth/sp/oidc/flows/TestConstants.java
@@ -106,7 +106,7 @@ public final class TestConstants {
      * Build cookie header bytes for the given parameters. These take the form of:
      * <pre>
      * __Host-_shibsp_req_{state}={nonce};
-     * __Host-shibsp_state__{appId}_{state}={targetURL};
+     * __Host-shibsp_state_{appId}_{state}={targetURL};
      * __Host-shibsp_authnstate_{state}={authn_request_json};
      * </pre>
      * 
@@ -129,7 +129,7 @@ public final class TestConstants {
         // Compose the header with semicolons and spacing as in the example
         final StringBuilder sb = new StringBuilder();
         sb.append("__Host-shibsp_req_").append(state).append('=').append(nonce).append(";\n");
-        sb.append("__Host-shibsp_state__").append(appID).append('_').append(state)
+        sb.append("__Host-shibsp_state_").append(appID).append('_').append(state)
           .append('=').append(targetUrlB64).append("; \n");
         sb.append("__Host-shibsp_authnstate_").append(state).append('=').append(authnJsonEnc).append(";\n");
         System.out.println(sb.toString());
diff --git a/sp-oidc-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/oidc-test.properties b/sp-oidc-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/oidc-test.properties
index 2148007..a63b89d 100644
--- a/sp-oidc-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/oidc-test.properties
+++ b/sp-oidc-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/oidc-test.properties
@@ -1,5 +1,7 @@
 # OIDC-specific RP test settings
 
+## TODO check where these are being used
+
 # Settings for RP public/private signing and encryption key(s)
 # During decryption key rollover, point the ".2" properties at a second
 # keypair, uncomment in credentials.xml, then publish it in your metadata.
@@ -19,14 +21,14 @@ sp.oidc.signing.rsa.enc.key = %{idp.home}/credentials/sp/sp-encryption-rsa.jwk
 
 sp.oidc.redirecturl.allowedOrigins = http://localhost
 
+#sp.oidc.extractStandardAttributes = true
+
 ## TEST ENC FOR NOW from profile config
 idp.oidc.requestobject.encrypted = false
 
 #sp.oidc.idtoken.validateAcrValue = true
-
 #sp.oidc.idtoken.jwt.verifier.clockSkew = PT60S
 #sp.oidc.idtoken.jwt.verifier.authnLifetime = PT60S
 #sp.oidc.idtoken.jwt.verifier.authnRequestClockSkew = PT0S
-
 #idp.oidc.encryption.config = dummy.oidc.EncryptionConfiguration
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.