[cpp-sp] 01/02: minor compiler issue

Codeberg noreply at shibboleth.net
Mon Aug 24 19:00:59 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/bfde03d0ad9c17542d84fe5560b605913ece0340

commit bfde03d0ad9c17542d84fe5560b605913ece0340
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon Aug 24 19:44:51 2026 +0100

    minor compiler issue
---
 shibsp/remoting/impl/AbstractHTTPRemotingService.cpp | 12 ++++++++++--
 shibsp/remoting/impl/WinHTTPRemotingService.cpp      |  4 ++--
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
index e0be4e08..2d888921 100644
--- a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
@@ -57,8 +57,8 @@ AbstractHTTPRemotingService::AbstractHTTPRemotingService(ptree& pt)
     static const char ENABLE_IP4_PROP_NAME[] = "enableIP4";
     static const char ENABLE_IP6_PROP_NAME[] = "enableIP6";
 
-    static const char DISABLE_TLS12_PROP_NAME[] = "enableTLS12";
-    static const char DISABLE_TLS13_PROP_NAME[] = "enableTLS13";
+    static const char DISABLE_TLS12_PROP_NAME[] = "disableTLS12";
+    static const char DISABLE_TLS13_PROP_NAME[] = "disableTLS13";
     static const char TLS12_CIPHER_LIST_PROP_NAME[] = "tls12CipherList";
     static const char TLS13_CIPHER_LIST_PROP_NAME[] = "tls13CipherList";
 
@@ -268,6 +268,14 @@ const string& AbstractHTTPRemotingService::getTLS13Ciphers() const {
     return m_traceFileBase;
 }
 
+bool AbstractHTTPRemotingService::isDisableTLS12() const {
+    return m_disableTLS12;
+}
+
+bool AbstractHTTPRemotingService::isDisableTLS13() const {
+    return m_disableTLS13;
+}
+
 const char* AbstractHTTPRemotingService::getCAFile() const
 {
     if (m_caFile.empty()) {
diff --git a/shibsp/remoting/impl/WinHTTPRemotingService.cpp b/shibsp/remoting/impl/WinHTTPRemotingService.cpp
index d88d7345..8c32f434 100644
--- a/shibsp/remoting/impl/WinHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/WinHTTPRemotingService.cpp
@@ -645,7 +645,7 @@ void WinHTTPRemotingService::handleCipher(HINTERNET handle) const
 
     if (secinfo.ConnectionInfo.dwProtocol == SP_PROT_TLS1_2_CLIENT) {
 
-        if (getCiphers().empty() || m_cipherSet.count(cipher)) {
+        if (getTLS12Ciphers().empty() || m_tls12CipherSet.count(cipher)) {
             // match, nothing to do
             return;
         }
@@ -654,7 +654,7 @@ void WinHTTPRemotingService::handleCipher(HINTERNET handle) const
     }
 
     if (secinfo.ConnectionInfo.dwProtocol == SP_PROT_TLS1_3_CLIENT) {
-        if (getTls13Ciphers().empty() || m_tls13CipherSet.count(cipher)) {
+        if (getTLS13Ciphers().empty() || m_tls13CipherSet.count(cipher)) {
             // match, nothing to do
             return;
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list