[cpp-sp] 02/02: CPPSP-63 Chunked IO has stopped working for WinHttp

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/0f73dd433d291a382e1dee2573ea195a8989b9b7

commit 0f73dd433d291a382e1dee2573ea195a8989b9b7
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu Aug 20 15:53:00 2026 +0100

    CPPSP-63 Chunked IO has stopped working for WinHttp
    
    https://shibboleth.atlassian.net/browse/CPPSP-63
    
    ifdef out the chunked IO support (for now)
---
 shibsp/remoting/impl/WinHTTPRemotingService.cpp | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/shibsp/remoting/impl/WinHTTPRemotingService.cpp b/shibsp/remoting/impl/WinHTTPRemotingService.cpp
index ce718daf..05ae2de4 100644
--- a/shibsp/remoting/impl/WinHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/WinHTTPRemotingService.cpp
@@ -413,6 +413,10 @@ void WinHTTPRemotingService::send(const char* path, istream& input, ostream& out
         throw RemotingException("Send failed");
     }
 
+#if 0
+    //
+    // As per CPPSP=73, chunked IO has regressed (when tested against the test harness)
+    //
     if (isChunked()) {
         //
         // Send the request, then the chunked data
@@ -456,8 +460,9 @@ void WinHTTPRemotingService::send(const char* path, istream& input, ostream& out
             m_log.crit("Send. Failed to send chunk header to %s : %d", path, GetLastError());
             throw RemotingException("Send failed");
         }
-    }
-    else {
+    } else 
+#endif
+    {
         //
         // Just buffer up all the data and send it in a wunner
         //

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.