[cpp-sp] branch maint-3 updated: SSPCPP-1012 - Add deprecation warnings where required

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch maint-3
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/e8b2f3bbbc1c52269f90facb4f648cb46a26f5d7

The following commit(s) were added to refs/heads/maint-3 by this push:
     new e8b2f3bb SSPCPP-1012 - Add deprecation warnings where required
e8b2f3bb is described below

commit e8b2f3bbbc1c52269f90facb4f648cb46a26f5d7
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Thu Aug 13 11:42:48 2026 -0400

    SSPCPP-1012 - Add deprecation warnings where required
    
    https://shibboleth.atlassian.net/browse/SSPCPP-1012
    
    "Final" round of warnings added.
---
 shibsp/AbstractSPRequest.cpp   | 1 -
 shibsp/ServiceProvider.cpp     | 1 +
 shibsp/impl/XMLApplication.cpp | 8 +++++++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/shibsp/AbstractSPRequest.cpp b/shibsp/AbstractSPRequest.cpp
index 36db1d4b..9f3407e2 100644
--- a/shibsp/AbstractSPRequest.cpp
+++ b/shibsp/AbstractSPRequest.cpp
@@ -312,7 +312,6 @@ string AbstractSPRequest::getSecureHeader(const char* name) const
 
 void AbstractSPRequest::setAuthType(const char* authtype)
 {
-
 }
 
 const char* AbstractSPRequest::getCookie(const char* name) const
diff --git a/shibsp/ServiceProvider.cpp b/shibsp/ServiceProvider.cpp
index 325858a1..a371f64f 100644
--- a/shibsp/ServiceProvider.cpp
+++ b/shibsp/ServiceProvider.cpp
@@ -609,6 +609,7 @@ pair<bool,long> ServiceProvider::doExport(SPRequest& request, bool requireSessio
         // Check for export of algorithmically-derived portion of cookie names.
         stdvars = settings.first->getBool("exportCookie");
         if (stdvars.first && stdvars.second) {
+            SPConfig::getConfig().deprecation().warn("exportCookie setting is removed from next major version");
             pair<string,const char*> cookieprops = app->getCookieNameProps(nullptr);
             app->setHeader(request, "Shib-Cookie-Name", cookieprops.first.c_str());
         }
diff --git a/shibsp/impl/XMLApplication.cpp b/shibsp/impl/XMLApplication.cpp
index b43c9566..8b9cfd46 100644
--- a/shibsp/impl/XMLApplication.cpp
+++ b/shibsp/impl/XMLApplication.cpp
@@ -134,6 +134,10 @@ XMLApplication::XMLApplication(
     // to ensure we get only our Sessions element.
     const PropertySet* sessionProps = getPropertySet("Sessions");
     if (sessionProps) {
+        if (sessionProps->getBool("sameSiteFallback").first) {
+            SPConfig::getConfig().deprecation().warn("sameSiteFallback setting is removed from next major version");
+        }
+
         pair<bool,const char*> prop = sessionProps->getString("redirectLimit");
         if (prop.first) {
             if (!strcmp(prop.second, "none"))
@@ -231,8 +235,9 @@ XMLApplication::XMLApplication(
 
     doAttributeInfo(log);
 
-    if (conf.isEnabled(SPConfig::Handlers))
+    if (conf.isEnabled(SPConfig::Handlers)) {
         doHandlers(pp, e, log);
+    }
 
     // Notification.
     const DOMNodeList* nlist = e->getElementsByTagNameNS(e->getNamespaceURI(), Notify);
@@ -426,6 +431,7 @@ void XMLApplication::doAttributeInfo(Category& log)
     m_attributePrefix.second = "HTTP_";
     pair<bool,const char*> prefix = getString("attributePrefix");
     if (prefix.first) {
+        SPConfig::getConfig().deprecation().warn("attributePrefix feature is removed in next major version");
 #ifdef HAVE_STRCASECMP
         if (!strcasecmp(prefix.second, "HTTP_")) {
 #else

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.