[java-plugin-shibd] 01/04: Add InvalidEvent transition to guard unexpected errors.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd/commit/5c7c2043334ecaaed47b6473547506cb19549140

commit 5c7c2043334ecaaed47b6473547506cb19549140
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Thu Aug 6 14:30:41 2026 -0400

    Add InvalidEvent transition to guard unexpected errors.
---
 .../META-INF/net/shibboleth/idp/flows/sp/consumer/consumer-flow.xml    | 1 +
 .../META-INF/net/shibboleth/idp/flows/sp/initiator/initiator-flow.xml  | 3 +++
 .../net/shibboleth/idp/flows/sp/logout/consumer/consumer-flow.xml      | 1 +
 .../net/shibboleth/idp/flows/sp/logout/initiator/initiator-flow.xml    | 3 +++
 4 files changed, 8 insertions(+)

diff --git a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/consumer-flow.xml b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/consumer-flow.xml
index a334d1c..d04b8c5 100644
--- a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/consumer-flow.xml
+++ b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/consumer/consumer-flow.xml
@@ -45,6 +45,7 @@
         <transition on="ReselectFlow" to="ReselectFlow" />
         <transition on="MessageProcessingError" to="MessageProcessingError" />
         <transition on="RuntimeException" to="RuntimeException" />
+        <transition on="#{!'proceed'.equals(currentEvent.id)}" to="InvalidEvent" />
     </global-transitions>
 
 </flow>
diff --git a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/initiator/initiator-flow.xml b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/initiator/initiator-flow.xml
index 6bc5542..a586575 100644
--- a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/initiator/initiator-flow.xml
+++ b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/initiator/initiator-flow.xml
@@ -17,6 +17,7 @@
 
     <!-- Error events to reflect back from this subflow. -->
     <end-state id="InvalidEvent" />
+    <end-state id="InvalidProfileConfiguration" />
     <end-state id="InvalidProfileContext" />
     <end-state id="InvalidRelyingPartyContext" />
     <end-state id="InvalidRelyingPartyConfiguration" />
@@ -34,11 +35,13 @@
 
     <global-transitions>
         <transition on-exception="java.lang.RuntimeException" to="LogRuntimeException" />
+        <transition on="InvalidProfileConfiguration" to="InvalidProfileConfiguration" />
         <transition on="InvalidProfileContext" to="InvalidProfileContext" />
         <transition on="InvalidRelyingPartyContext" to="InvalidRelyingPartyContext" />
         <transition on="InvalidRelyingPartyConfiguration" to="InvalidRelyingPartyConfiguration" />
         <transition on="ReselectFlow" to="ReselectFlow" />
         <transition on="RuntimeException" to="RuntimeException" />
+        <transition on="#{!'proceed'.equals(currentEvent.id)}" to="InvalidEvent" />
     </global-transitions>
 
     <bean-import resource="classpath:/META-INF/net/shibboleth/idp/flows/sp/initiator/initiator-beans.xml" />
diff --git a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/consumer/consumer-flow.xml b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/consumer/consumer-flow.xml
index 1a4d381..4b7aad1 100644
--- a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/consumer/consumer-flow.xml
+++ b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/consumer/consumer-flow.xml
@@ -47,6 +47,7 @@
         <transition on="MessageProcessingError" to="MessageProcessingError" />
         <transition on="RuntimeException" to="RuntimeException" />
         <transition on="UnableToDecode" to="UnableToDecode" />
+        <transition on="#{!'proceed'.equals(currentEvent.id)}" to="InvalidEvent" />
     </global-transitions>
 
 </flow>
diff --git a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/initiator-flow.xml b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/initiator-flow.xml
index 4b5b283..18e0f0e 100644
--- a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/initiator-flow.xml
+++ b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/logout/initiator/initiator-flow.xml
@@ -17,6 +17,7 @@
 
     <!-- Error events to reflect back from this subflow. -->
     <end-state id="InvalidEvent" />
+    <end-state id="InvalidProfileConfiguration" />
     <end-state id="InvalidProfileContext" />
     <end-state id="InvalidRelyingPartyContext" />
     <end-state id="InvalidRelyingPartyConfiguration" />
@@ -34,11 +35,13 @@
 
     <global-transitions>
         <transition on-exception="java.lang.RuntimeException" to="LogRuntimeException" />
+        <transition on="InvalidProfileConfiguration" to="InvalidProfileConfiguration" />
         <transition on="InvalidProfileContext" to="InvalidProfileContext" />
         <transition on="InvalidRelyingPartyContext" to="InvalidRelyingPartyContext" />
         <transition on="InvalidRelyingPartyConfiguration" to="InvalidRelyingPartyConfiguration" />
         <transition on="ReselectFlow" to="ReselectFlow" />
         <transition on="RuntimeException" to="RuntimeException" />
+        <transition on="#{!'proceed'.equals(currentEvent.id)}" to="InvalidEvent" />
     </global-transitions>
 
 </flow>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.