[java-shib-shared] branch main updated: JSSH-77 Mis-spelled class UsernamePasswoordCredentialsFactoryBean

Codeberg noreply at shibboleth.net
Thu Aug 6 14:16:21 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
https://codeberg.org/Shibboleth/java-shib-shared/commit/e6a2ea6f0e5094201cf6928f10d68a59ea37bb3b

The following commit(s) were added to refs/heads/main by this push:
     new e6a2ea6f JSSH-77 Mis-spelled class UsernamePasswoordCredentialsFactoryBean
e6a2ea6f is described below

commit e6a2ea6f0e5094201cf6928f10d68a59ea37bb3b
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu Aug 6 15:15:20 2026 +0100

    JSSH-77 Mis-spelled class UsernamePasswoordCredentialsFactoryBean
    
    https://shibboleth.atlassian.net/browse/JSSH-77
---
 .../UsernamePasswoordCredentialsFactoryBean.java   | 54 +++-------------------
 ...=> UsernamePasswordCredentialsFactoryBean.java} |  4 +-
 2 files changed, 9 insertions(+), 49 deletions(-)

diff --git a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java
index 83f50ecc..2fab9375 100644
--- a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java
+++ b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java
@@ -14,13 +14,10 @@
 
 package net.shibboleth.shared.spring.httpclient.factory;
 
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
 import org.apache.hc.client5.http.auth.UsernamePasswordCredentials;
-import org.springframework.beans.factory.BeanCreationException;
 
-import net.shibboleth.shared.spring.factory.AbstractComponentAwareFactoryBean;
+import net.shibboleth.shared.primitive.DeprecationSupport;
+import net.shibboleth.shared.primitive.DeprecationSupport.ObjectType;
 
 /**
  * Factory bean for {@link UsernamePasswordCredentials}.
@@ -28,49 +25,12 @@ import net.shibboleth.shared.spring.factory.AbstractComponentAwareFactoryBean;
  * <p>Mainly for insulation from Apache client API.</p>
  * 
  * @since 9.0.0
+ * @deprecated use {@link UsernamePasswordCredentials}
  */
-public class UsernamePasswoordCredentialsFactoryBean
-        extends AbstractComponentAwareFactoryBean<UsernamePasswordCredentials> {
-
-    /** The username. */
-    @Nullable private String username;
-
-    /** The password. */
-    @Nullable private String password;
-
-    /** {@inheritDoc} */
-    @Override
-    @Nonnull public Class<?> getObjectType() {
-        return UsernamePasswordCredentials.class;
-    }
+public class UsernamePasswoordCredentialsFactoryBean extends UsernamePasswordCredentialsFactoryBean {
 
-    /**
-     * Set the username.
-     * 
-     * @param what value to set
-     */
-    public void setUsername(@Nullable final String what) {
-        username = what;
+    public UsernamePasswoordCredentialsFactoryBean() {
+        super();
+        DeprecationSupport.warnOnce(ObjectType.CLASS, "UsernamePasswoordCredentialsFactoryBean", null, "UsernamePasswordCredentialsFactoryBean");
     }
-
-    /**
-     * Set the password.
-     * 
-     * @param what value to set
-     */
-    public void setPassword(@Nullable final String what) {
-        password = what;
-    }
-
-    /** {@inheritDoc} */
-    @Override
-    @Nonnull protected UsernamePasswordCredentials doCreateInstance() throws Exception {
-        if (username == null || password == null) {
-            throw new BeanCreationException("Username and password cannot be null");
-        }
-        
-        assert password != null;
-        return new UsernamePasswordCredentials(username, password.toCharArray());
-    }
-
 }
\ No newline at end of file
diff --git a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswordCredentialsFactoryBean.java
similarity index 96%
copy from shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java
copy to shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswordCredentialsFactoryBean.java
index 83f50ecc..f29ddc4b 100644
--- a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswoordCredentialsFactoryBean.java
+++ b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/UsernamePasswordCredentialsFactoryBean.java
@@ -27,9 +27,9 @@ import net.shibboleth.shared.spring.factory.AbstractComponentAwareFactoryBean;
  * 
  * <p>Mainly for insulation from Apache client API.</p>
  * 
- * @since 9.0.0
+ * @since 9.3.0
  */
-public class UsernamePasswoordCredentialsFactoryBean
+public class UsernamePasswordCredentialsFactoryBean
         extends AbstractComponentAwareFactoryBean<UsernamePasswordCredentials> {
 
     /** The username. */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list