[cpp-sp] 02/03: Tidy up batch file comments

Codeberg noreply at shibboleth.net
Wed Apr 15 13:37:26 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/b2a9083056c23f872e8686ffed9e9db5afd6bd01

commit b2a9083056c23f872e8686ffed9e9db5afd6bd01
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Apr 15 13:47:18 2026 +0100

    Tidy up batch file comments
---
 Projects/vc22/build.bat      | 10 +++++-----
 WindowsInstall/doupdate.bat  | 32 ++++++++++++++++----------------
 WindowsInstall/install.bat   | 10 +++++-----
 WindowsInstall/uninstall.bat |  6 +++---
 WindowsInstall/update.bat    |  8 ++++----
 5 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/Projects/vc22/build.bat b/Projects/vc22/build.bat
index 04c9dcb2..7ef3392f 100644
--- a/Projects/vc22/build.bat
+++ b/Projects/vc22/build.bat
@@ -10,7 +10,7 @@ set BUILD_HOME_DIR=%cd%
 
 cd projects/VC22
 
-rem Clean
+Rem Clean
 del /s *.obj *.lib *.dll *.exe
 del /s *.obj *.lib *.dll *.exe
 
@@ -19,16 +19,16 @@ if exist kit.zip del kit.zip
 if exist kit rd /s /q kit
 
 
-REM Build all the DLLS and the msiversion executable
+Rem Build all the DLLS and the msiversion executable
 
-REM everything for x64
+Rem everything for x64
 msbuild -m /property:Platform=x64;Configuration=release /MaxCPUCount Shibboleth.sln /t:iis;NativeLogMessages;Version;Apache
 
-REM IIS only for Arm64 and x86
+Rem IIS only for Arm64 and x86
 msbuild -m /property:Platform=arm64;Configuration=release /MaxCPUCount Shibboleth.sln /t:iis
 msbuild -m /property:Platform=x86;Configuration=release /MaxCPUCount Shibboleth.sln /t:iis
 
-REM Build Kit.
+Rem Build Kit.
 
 mkdir kit
 copy ..\..\WindowsInstall\install.bat kit\
diff --git a/WindowsInstall/doupdate.bat b/WindowsInstall/doupdate.bat
index 865d17e4..df4a6588 100644
--- a/WindowsInstall/doupdate.bat
+++ b/WindowsInstall/doupdate.bat
@@ -1,15 +1,15 @@
-rem @echo off
-REM Update  SP agent
+Rem @echo off
+Rem Update SP agent
 
 setlocal
 
-rem Find FQP for target and root of installation
+Rem Find FQP for target and root of installation
 set SAVE_WORKING_DIR=%cd%
 cd %1%
 set TargetDir=%cd%
 
 cd /d %~dp0..
-Echo "Installing from %cd%"
+echo "Installing from %cd%"
 
 Rem Grab version as string
 for /f "delims=" %%a IN (version.txt) do (set /a Version=%%a)
@@ -24,12 +24,12 @@ if exist %TargetDir%\lib\shibboleth-sp (
   Echo Installing SP Agent Version %VersionString%
 )
 
-rem
-rem use robocopy to copy stuff over
-rem /s recursive
-rem /is copy eveything
-rem /njh No job header
-rem /njs No job summary
+Rem
+Rem use robocopy to copy stuff over
+Rem /s recursive
+Rem /is copy eveything
+Rem /njh No job header
+Rem /njs No job summary
 echo Copying Distribution to %targetDir%\dist-%VersionString%
 mkdir  "%targetDir%\dist-%VersionString%"
 robocopy /s /is /njs /njh . "%targetDir%\dist-%VersionString%"
@@ -42,16 +42,16 @@ echo Copying Dll Files to  %targetdir%\lib\shibboleth-sp\
 mkdir "%targetdir%\lib\shibboleth-sp\"
 robocopy /is /njs /njh lib "%targetdir%\lib\shibboleth-sp"
 
-rem /xc /xn /xo only new files
-rem  /xc exclude existing files same timestamp different sizes
-rem  /xn exclude newer
-rem  /xo exclude older
-rem Hence /xo /xc /xn means "copy every file where a file of that name isn't there"
+Rem /xc /xn /xo only new files
+Rem  /xc exclude existing files same timestamp different sizes
+Rem  /xn exclude newer
+Rem  /xo exclude older
+Rem Hence /xo /xc /xn means "copy every file where a file of that name isn't there"
 echo Copying new config Files
 mkdir "%targetdir%\etc\shibboleth-sp\"
 robocopy /xc /xn /xo /njs /njh etc "%targetdir%\etc\shibboleth-sp"
 
-rem Set registry
+Rem Set registry
 echo "just add code to update registry"
 exit /b
 
diff --git a/WindowsInstall/install.bat b/WindowsInstall/install.bat
index 2cb96993..d1a76737 100644
--- a/WindowsInstall/install.bat
+++ b/WindowsInstall/install.bat
@@ -1,19 +1,19 @@
-rem @echo off
-REM Install SP agent
+Rem @echo off
+Rem Install SP agent
 
 setlocal
 
-rem Find FQP for root of installation
+Rem Find FQP for root of installation
 set SAVE_WORKING_DIR=%cd%
 cd /d %~dp0
 set SOURCE_DIR=%cd%
 
-rem - Collect targetDir [opt\shibboleth-sp]
+Rem - Collect targetDir [opt\shibboleth-sp]
 set loc=%SystemDrive%\opt\shibboleth-sp
 set /p TargetDir="Location To Install [%loc%] :"
 if "%TargetDir%" == "" set TargetDir=%loc%
 
-rem - Fail if lib or bin exist
+Rem - Fail if lib or bin exist
 if exist "%TargetDir%\bin\shibboleth-sp" (
     echo %TargetDir%\bin\shibboleth-sp exists.  Agent may already be installed
     echo Did you mean %TargetDir%\bin\shibboleth-sp\update ?
diff --git a/WindowsInstall/uninstall.bat b/WindowsInstall/uninstall.bat
index 4b0314ee..4a2ab7fe 100644
--- a/WindowsInstall/uninstall.bat
+++ b/WindowsInstall/uninstall.bat
@@ -1,7 +1,7 @@
 setlocal
-REM
-REM File to uninstall the SP agent
-REM
+Rem
+Rem File to uninstall the SP agent
+Rem
 
 Rem Goto root of install - we are running from %targetDir%\dist-4.x.7\dist-bin\
 
diff --git a/WindowsInstall/update.bat b/WindowsInstall/update.bat
index d9661548..0a5aacf2 100644
--- a/WindowsInstall/update.bat
+++ b/WindowsInstall/update.bat
@@ -1,10 +1,10 @@
-rem @echo off
+Rem @echo off
 
 setlocal
 
-rem fail if parameters is not a distribution
+Rem fail if parameters is not a distribution
 
-rem find kit root
+Rem find kit root
 cd %1%
 set kit_root=%CD%
 
@@ -13,7 +13,7 @@ if not exist "dist\dist-bin\doupdate.bat" (
    exit /b
 )
 
-rem find root of install
+Rem find root of install
 cd %~dp0..\..
 set install_path=%cd%
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list