[java-plugin-shibd-oidc] branch main updated: Default errorFatal to true for mapping state token to state value

Codeberg noreply at shibboleth.net
Mon Apr 13 09:46:02 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd-oidc.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-oidc/commit/4f14b1fd3e1ea4b4040eb9eccb904870b274edd1

The following commit(s) were added to refs/heads/main by this push:
     new 4f14b1f  Default errorFatal to true for mapping state token to state value
4f14b1f is described below

commit 4f14b1fd3e1ea4b4040eb9eccb904870b274edd1
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Apr 13 10:45:53 2026 +0100

    Default errorFatal to true for mapping state token to state value
---
 .../sp/oidc/profile/impl/MapStateTokenToStateValue.java    | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/sp-oidc-impl/src/main/java/net/shibboleth/sp/oidc/profile/impl/MapStateTokenToStateValue.java b/sp-oidc-impl/src/main/java/net/shibboleth/sp/oidc/profile/impl/MapStateTokenToStateValue.java
index 2e09a18..64d64c0 100644
--- a/sp-oidc-impl/src/main/java/net/shibboleth/sp/oidc/profile/impl/MapStateTokenToStateValue.java
+++ b/sp-oidc-impl/src/main/java/net/shibboleth/sp/oidc/profile/impl/MapStateTokenToStateValue.java
@@ -44,6 +44,9 @@ import net.shibboleth.sp.profile.AbstractApplicationAction;
  * <p>This action does not interpret the state value itself. Instead, the token value consumer is expected to 
  * understand the structure and semantics of the recovered state value and set it on the {@link ProfileRequestContext} 
  * appropriately.</p>
+ * 
+ * @event {@link EventIds#PROCEED_EVENT_ID}
+ * @event {@link EventIds#INVALID_MESSAGE}
  */
 public class MapStateTokenToStateValue extends AbstractApplicationAction {
     
@@ -60,9 +63,16 @@ public class MapStateTokenToStateValue extends AbstractApplicationAction {
      */
     @NonnullAfterInit private BiFunction<ProfileRequestContext, byte[], Boolean> stateValueConsumer;
     
-    /** Whether an error mapping the state token to a state value is fatal. */
+    /** Whether an error mapping the state token to a state value is fatal. Defaults to true. */
     private boolean errorFatal;
     
+    /**
+     * Constructor.
+     */
+    public MapStateTokenToStateValue() {
+        errorFatal = true;
+    }
+    
     /**
      * Sets the lookup strategy to obtain the protocol specific state token. 
      *
@@ -88,7 +98,7 @@ public class MapStateTokenToStateValue extends AbstractApplicationAction {
     /**
      * Sets whether an error looking up a state value from a state token should result in a fatal event.
      * 
-     * <p>Defaults to false.</p>
+     * <p>Defaults to true.</p>
      * 
      * @param flag flag to set
      */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list