[java-shib-profile] branch main updated: Improve javadoc.

Scott Cantor cantor.2 at osu.edu
Thu Sep 25 13:54:15 UTC 2025


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-profile.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-profile.git;a=commit;h=4b171fec2d16dab3ffd65b4fc0bf97f3bd13515e

The following commit(s) were added to refs/heads/main by this push:
     new 4b171fe  Improve javadoc.
4b171fe is described below

commit 4b171fec2d16dab3ffd65b4fc0bf97f3bd13515e
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Sep 25 09:53:58 2025 -0400

    Improve javadoc.
---
 .../profile/context/logic/AbstractAttributePredicate.java          | 2 ++
 .../shibboleth/profile/context/logic/SimpleAttributePredicate.java | 7 ++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/AbstractAttributePredicate.java b/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/AbstractAttributePredicate.java
index 567f2d3..675c5b2 100644
--- a/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/AbstractAttributePredicate.java
+++ b/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/AbstractAttributePredicate.java
@@ -117,6 +117,8 @@ public abstract class AbstractAttributePredicate implements Predicate<ProfileReq
     /**
      * Get the result of the predicate in the case the attribute context is null.
      * 
+     * <p>Defaults to false unless overridden by a subclass.</p>
+     * 
      * @return null context result
      */
     protected boolean allowNullAttributeContext() {
diff --git a/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/SimpleAttributePredicate.java b/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/SimpleAttributePredicate.java
index 92d037d..1ae9bb6 100644
--- a/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/SimpleAttributePredicate.java
+++ b/shib-profile-api/src/main/java/net/shibboleth/profile/context/logic/SimpleAttributePredicate.java
@@ -93,7 +93,12 @@ public class SimpleAttributePredicate extends AbstractAttributePredicate {
         scope = StringSupport.trimOrNull(s);
     }
 
-    /** {@inheritDoc} */
+    /**
+     * {@inheritDoc}
+     * 
+     * <p>This will return false unless no values and scope to check for were specified
+     * to the condition.</p>
+     */
     @Override
     protected boolean allowNullAttributeContext() {
         return attributeValueMap.isEmpty() && scope == null;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list