[cpp-sp] branch main updated: Fix a couple of windows build issues

Rod Widdowson rdw at steadingsoftware.com
Wed Sep 24 11:04:05 UTC 2025


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=6be3e91dbce0323d8d9903252ba3577a21500888

The following commit(s) were added to refs/heads/main by this push:
     new 6be3e91d Fix a couple of windows build issues
6be3e91d is described below

commit 6be3e91dbce0323d8d9903252ba3577a21500888
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Sep 24 12:03:14 2025 +0100

    Fix a couple of windows build issues
---
 shibsp/remoting/impl/WinHTTPRemotingService.cpp | 1 +
 shibsp/session/impl/AbstractSessionCache.cpp    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/shibsp/remoting/impl/WinHTTPRemotingService.cpp b/shibsp/remoting/impl/WinHTTPRemotingService.cpp
index 1d32e91b..5cb7d624 100644
--- a/shibsp/remoting/impl/WinHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/WinHTTPRemotingService.cpp
@@ -412,6 +412,7 @@ void WinHTTPRemotingService::send(const char* path, istream& input, ostream& out
                     nullptr)) {
             m_log.crit("Send. Failed to setup dummy AuthN to %s : %d", path, GetLastError());
             throw RemotingException("Send failed");
+        }
     }
 
     wchar_t headers[]= L"Content-Type: text/plain\r\nExpect:";
diff --git a/shibsp/session/impl/AbstractSessionCache.cpp b/shibsp/session/impl/AbstractSessionCache.cpp
index 28f9cd28..19142971 100644
--- a/shibsp/session/impl/AbstractSessionCache.cpp
+++ b/shibsp/session/impl/AbstractSessionCache.cpp
@@ -306,7 +306,7 @@ pair<string,unsigned int> AbstractSessionCache::parseCookieValue(const char* val
         // Shouldn't happen, but we can handle it.
         return make_pair(string(value), 1);
     }
-    else if (!isnumber(*(sep + 1))) {
+    else if (!isdigit(*(sep + 1))) {
         // Check for negative
         return make_pair(string(value, sep), 1);
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list