[cpp-sp] branch main updated: AbstractHTTPRemotingService: return null for an empty string

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=1337b248c91643175fe1224f3e55c28d54b88a62

The following commit(s) were added to refs/heads/main by this push:
     new 1337b248 AbstractHTTPRemotingService: return null for an empty string
1337b248 is described below

commit 1337b248c91643175fe1224f3e55c28d54b88a62
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri Oct 31 16:40:56 2025 +0000

    AbstractHTTPRemotingService: return null for an empty string
    
    The remoting services check for the absence of a CA file by saying
    
        if (getCAFile())
    
    But and empty string can have an address (pointing to "\0")
---
 shibsp/remoting/impl/AbstractHTTPRemotingService.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
index b1b50d52..5f13d008 100644
--- a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
@@ -198,6 +198,9 @@ bool AbstractHTTPRemotingService::isRevocationCheck() const
 
 const char* AbstractHTTPRemotingService::getCAFile() const
 {
+    if (m_caFile.empty()) {
+        return nullptr;
+    }
     return m_caFile.c_str();
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.