[cpp-sp] branch main updated: Yet more test fixes.

Scott Cantor cantor.2 at osu.edu
Mon Oct 20 14:16:53 UTC 2025


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=739191f262d82483c0c1cdc0ffa95d920ca4d8d6

The following commit(s) were added to refs/heads/main by this push:
     new 739191f2 Yet more test fixes.
739191f2 is described below

commit 739191f262d82483c0c1cdc0ffa95d920ca4d8d6
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Oct 20 10:16:49 2025 -0400

    Yet more test fixes.
---
 tests/remoting/impl/RemotingServiceTests.cpp |  6 ++++++
 tests/util/BoostPropertySetTests.cpp         | 10 +++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/tests/remoting/impl/RemotingServiceTests.cpp b/tests/remoting/impl/RemotingServiceTests.cpp
index 57e0935d..7b98efad 100644
--- a/tests/remoting/impl/RemotingServiceTests.cpp
+++ b/tests/remoting/impl/RemotingServiceTests.cpp
@@ -40,6 +40,7 @@ using namespace std;
 
 namespace {
 
+#ifdef HAVE_CXX14
 // Used as test decorator for any tests requiring testbed.
 struct testbedRunning {
     boost::test_tools::assertion_result operator()(boost::unit_test::test_unit_id) {
@@ -47,6 +48,7 @@ struct testbedRunning {
         return var && *var == '1';
     }
 };
+#endif
 
 struct RemotingFixture
 {
@@ -64,6 +66,8 @@ struct RemotingFixture
 
 /////////////
 
+#ifdef HAVE_CXX14
+
 BOOST_FIXTURE_TEST_CASE(RemotingService_startup, RemotingFixture)
 {
     AgentConfig::getConfig().getAgent().getRemotingService();
@@ -92,4 +96,6 @@ BOOST_FIXTURE_TEST_CASE(RemotingService_ping, RemotingFixture, * boost::unit_tes
     BOOST_CHECK_LE(output2.getmember("epoch").longinteger(), time(nullptr));
 }
 
+#endif
+
 };
\ No newline at end of file
diff --git a/tests/util/BoostPropertySetTests.cpp b/tests/util/BoostPropertySetTests.cpp
index f389fd9a..7657ccb9 100644
--- a/tests/util/BoostPropertySetTests.cpp
+++ b/tests/util/BoostPropertySetTests.cpp
@@ -115,25 +115,25 @@ BOOST_FIXTURE_TEST_CASE(BoostPropertySet_tree, BPS_Fixture)
     BOOST_CHECK_EQUAL(twos.size(), 2);
     BOOST_CHECK_EQUAL(rootset.getString("foo"), "bar");
     BOOST_CHECK_EQUAL(rootset.getString("zork"), "frobnitz");
-    BOOST_CHECK_EQUAL(rootset.getString(BoostPropertySet::XMLATTR_NODE_NAME), nullptr);
+    BOOST_CHECK(!rootset.getString(BoostPropertySet::XMLATTR_NODE_NAME));
     BOOST_CHECK_EQUAL(rootset.getString("one"), nullptr);
 
     BOOST_CHECK_EQUAL(ones[0]->getString("foo"), "baz");
     BOOST_CHECK_EQUAL(ones[0]->getString("zork"), "frobnitz");
-    BOOST_CHECK_EQUAL(ones[0]->getString(BoostPropertySet::XMLATTR_NODE_NAME), nullptr);
+    BOOST_CHECK(!ones[0]->getString(BoostPropertySet::XMLATTR_NODE_NAME));
     BOOST_CHECK_EQUAL(ones[0]->getString("two"), nullptr);
 
     BOOST_CHECK_EQUAL(ones[1]->getString("foo", "zork"), "zork");
     BOOST_CHECK_EQUAL(ones[1]->getString("zork"), nullptr);
-    BOOST_CHECK_EQUAL(ones[1]->getString(BoostPropertySet::XMLATTR_NODE_NAME), nullptr);
+    BOOST_CHECK(!ones[1]->getString(BoostPropertySet::XMLATTR_NODE_NAME));
     BOOST_CHECK_EQUAL(ones[1]->getString("two"), nullptr);
 
     BOOST_CHECK_EQUAL(twos[0]->getString("foo"), "baz");
     BOOST_CHECK_EQUAL(twos[0]->getString("zork"), "frobnitz");
-    BOOST_CHECK_EQUAL(twos[0]->getString(BoostPropertySet::XMLATTR_NODE_NAME), nullptr);
+    BOOST_CHECK(!twos[0]->getString(BoostPropertySet::XMLATTR_NODE_NAME));
 
     BOOST_CHECK_EQUAL(twos[1]->getString("unset"), "foo zork");
     BOOST_CHECK_EQUAL(twos[1]->getString("foo"), nullptr);
     BOOST_CHECK_EQUAL(twos[1]->getString("zork"), "zorkmid");
-    BOOST_CHECK_EQUAL(twos[1]->getString(BoostPropertySet::XMLATTR_NODE_NAME), nullptr);
+    BOOST_CHECK(!twos[1]->getString(BoostPropertySet::XMLATTR_NODE_NAME));
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list