[java-plugin-shibd] branch main updated: Missed commit.
Codeberg
noreply at shibboleth.net
Sat Nov 22 00:21:12 UTC 2025
This is an automated email from the git hooks/post-receive script.
codeberg pushed a commit to branch main
in repository java-plugin-shibd.
View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd/commit/6d49f94cea9a27e0a81beb1484e8c263025c7313
The following commit(s) were added to refs/heads/main by this push:
new 6d49f94 Missed commit.
6d49f94 is described below
commit 6d49f94cea9a27e0a81beb1484e8c263025c7313
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Nov 21 19:20:56 2025 -0500
Missed commit.
---
.../sp/profile/impl/DoStorageOperationTest.java | 63 ++++++++--------------
1 file changed, 23 insertions(+), 40 deletions(-)
diff --git a/sp-server-impl/src/test/java/net/shibboleth/sp/profile/impl/DoStorageOperationTest.java b/sp-server-impl/src/test/java/net/shibboleth/sp/profile/impl/DoStorageOperationTest.java
index e17ab76..013d3b3 100644
--- a/sp-server-impl/src/test/java/net/shibboleth/sp/profile/impl/DoStorageOperationTest.java
+++ b/sp-server-impl/src/test/java/net/shibboleth/sp/profile/impl/DoStorageOperationTest.java
@@ -97,11 +97,11 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
* Test invalidMethod
*/
@Test
- public void invalidMethod() {
+ public void missingOp() {
arc.setInput(new DDF().structure());
- request.setMethod("FOO");
+ request.setMethod("POST");
final Event event = action.execute(src);
ActionTestingSupport.assertEvent(event, EventIds.INVALID_MESSAGE);
@@ -113,9 +113,11 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
*/
@Test
public void readNoParams() {
- arc.setInput(new DDF().structure());
+ final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("R");
+ arc.setInput(input);
- request.setMethod("GET");
+ request.setMethod("POST");
final Event event = action.execute(src);
ActionTestingSupport.assertEvent(event, EventIds.INVALID_MESSAGE);
@@ -127,9 +129,10 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
@Test
public void missingRead() {
- request.setMethod("GET");
+ request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("R");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
arc.setInput(input);
@@ -143,7 +146,7 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
}
/**
- * Test successful get.
+ * Test successful read.
*
* @throws IOException
*/
@@ -154,9 +157,10 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
storageService.create(AGENT_CONTEXT, KEY, VALUE, exp);
- request.setMethod("GET");
+ request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("R");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
arc.setInput(input);
@@ -183,9 +187,10 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
storageService.create(AGENT_CONTEXT, KEY, VALUE, null);
- request.setMethod("DELETE");
+ request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("D");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY + "2");
arc.setInput(input);
@@ -210,9 +215,10 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
storageService.create(AGENT_CONTEXT, KEY, VALUE, null);
- request.setMethod("DELETE");
+ request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("D");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
arc.setInput(input);
@@ -235,9 +241,10 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
@Test
public void successCreate() throws IOException {
- request.setMethod("PUT");
+ request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("C");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
input.addmember(DoStorageOperation.VALUE).string(VALUE);
@@ -266,9 +273,10 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
storageService.create(AGENT_CONTEXT, KEY, VALUE, null);
- request.setMethod("PUT");
+ request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("C");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
input.addmember(DoStorageOperation.VALUE).string(VALUE);
@@ -295,6 +303,7 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("U");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
input.addmember(DoStorageOperation.VALUE).string("changed");
@@ -313,35 +322,6 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
Assert.assertEquals(record.getValue(), "changed");
}
- /**
- * Test successful update as a create.
- *
- * @throws IOException
- */
- @Test
- public void successUpdateAsCreate() throws IOException {
-
- request.setMethod("POST");
-
- final DDF input = new DDF().structure();
- input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
- input.addmember(DoStorageOperation.KEY).string(KEY);
- input.addmember(DoStorageOperation.VALUE).string(VALUE);
- arc.setInput(input);
-
- final Event event = action.execute(src);
-
- ActionTestingSupport.assertProceedEvent(event);
-
- final DDF output = arc.getOutput();
- Assert.assertNull(output);
-
- final StorageRecord<?> record = storageService.read(AGENT_CONTEXT, KEY);
- assert record != null;
- Assert.assertEquals(record.getVersion(), 1);
- Assert.assertEquals(record.getValue(), VALUE);
- }
-
/**
* Test successful update with a version.
*
@@ -355,6 +335,7 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("U");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
input.addmember(DoStorageOperation.VALUE).string("changed");
@@ -388,6 +369,7 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("U");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
input.addmember(DoStorageOperation.VALUE).string("changed");
@@ -418,6 +400,7 @@ public class DoStorageOperationTest extends BaseAgentRequestTest {
request.setMethod("POST");
final DDF input = new DDF().structure();
+ input.addmember(DoStorageOperation.OP).string("U");
input.addmember(DoStorageOperation.CONTEXT).string(CONTEXT);
input.addmember(DoStorageOperation.KEY).string(KEY);
input.addmember(DoStorageOperation.VALUE).string("changed");
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list