[java-plugin-shibd] branch main updated: Disallow use of bang character in agent IDs for storage service safety.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd/commit/5d0e8ea763283d6cbbfd9bc7470103ed54c20c53

The following commit(s) were added to refs/heads/main by this push:
     new 5d0e8ea  Disallow use of bang character in agent IDs for storage service safety.
5d0e8ea is described below

commit 5d0e8ea763283d6cbbfd9bc7470103ed54c20c53
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Nov 20 16:18:20 2025 -0500

    Disallow use of bang character in agent IDs for storage service safety.
---
 sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java b/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java
index c51393d..4141f8d 100644
--- a/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java
+++ b/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java
@@ -284,6 +284,10 @@ public class BasicAgent extends BasicApplication implements Agent {
     protected void doInitialize() throws ComponentInitializationException {
         super.doInitialize();
         
+        if (ensureId().contains("!")) {
+            throw new ComponentInitializationException("Agent ID cannot contain bang character (!)");
+        }
+        
         // Install us into each child Application.
         for (final Application a : applicationMap.values()) {
             if (a instanceof BasicApplication app) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.