[java-idp-plugin-oidc-op-oidfed] branch main updated: Switched local container fetching strategies back to returning null

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-plugin-oidc-op-oidfed.

View the commit online:
https://git.shibboleth.net/view/?p=java-idp-plugin-oidc-op-oidfed.git;a=commit;h=56541378ed9d849fba317fe351f989d0da680ec8

The following commit(s) were added to refs/heads/main by this push:
     new 5654137  Switched local container fetching strategies back to returning null
5654137 is described below

commit 56541378ed9d849fba317fe351f989d0da680ec8
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Thu Nov 13 12:24:54 2025 +0200

    Switched local container fetching strategies back to returning null
    
    This approach produces some WARN-loglines from the metadata cache, but a separate issue is filed to oidc-commons about it:
    https://shibboleth.atlassian.net/browse/JCOMOIDC-146
    
    The instantly expiring null-response approach was causing issues in Windows environment, as Instant.now() there doesn't provide precise-enough timestamp for expiration.
---
 .../metadata/DefaultEntityConfigurationResponseFetchingStrategy.java | 5 ++---
 .../metadata/DefaultResolveEntityResponseFetchingStrategy.java       | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultEntityConfigurationResponseFetchingStrategy.java b/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultEntityConfigurationResponseFetchingStrategy.java
index 53e0d30..1862386 100644
--- a/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultEntityConfigurationResponseFetchingStrategy.java
+++ b/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultEntityConfigurationResponseFetchingStrategy.java
@@ -14,7 +14,6 @@
 
 package net.shibboleth.idp.plugin.oidc.op.oidfed.metadata;
 
-import java.time.Instant;
 import java.util.function.Function;
 
 import javax.annotation.Nonnull;
@@ -46,8 +45,8 @@ public class DefaultEntityConfigurationResponseFetchingStrategy extends Abstract
         }
         final NimbusResponseCriterion responseCriterion = criteria.get(NimbusResponseCriterion.class);
         if (responseCriterion == null) {
-            log.debug("No response criterion given, returning container with a null response expiring now");
-            return new NimbusResponseContainer(null, Instant.now());
+            log.debug("No response criterion given, returning null");
+            return null;
         }
         final ResponseContainerExpirationCriterion expirationCriterion =
                 criteria.get(ResponseContainerExpirationCriterion.class);
diff --git a/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultResolveEntityResponseFetchingStrategy.java b/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultResolveEntityResponseFetchingStrategy.java
index 0cbbd0b..c63e5b8 100644
--- a/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultResolveEntityResponseFetchingStrategy.java
+++ b/idp-oidfed-op-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultResolveEntityResponseFetchingStrategy.java
@@ -14,7 +14,6 @@
 
 package net.shibboleth.idp.plugin.oidc.op.oidfed.metadata;
 
-import java.time.Instant;
 import java.util.function.Function;
 
 import javax.annotation.Nonnull;
@@ -52,8 +51,8 @@ public class DefaultResolveEntityResponseFetchingStrategy extends AbstractIdenti
         }
         final NimbusResponseCriterion responseCriterion = criteria.get(NimbusResponseCriterion.class);
         if (responseCriterion == null) {
-            log.debug("No response criterion given, returning container with a null response expiring now");
-            return new ResolveEntityResponseContainer(null, requestCriterion.getRequest(), Instant.now());
+            log.debug("No response criterion given, returning null");
+            return null;
         }
         final ResponseContainerExpirationCriterion expirationCriterion =
                 criteria.get(ResponseContainerExpirationCriterion.class);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.