[cpp-sp] branch main updated: Reset trust list default to empty string.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=68c5ecd0538855fd0d861e7c37b57dbf7ebd8ff4

The following commit(s) were added to refs/heads/main by this push:
     new 68c5ecd0 Reset trust list default to empty string.
68c5ecd0 is described below

commit 68c5ecd0538855fd0d861e7c37b57dbf7ebd8ff4
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Nov 3 08:54:18 2025 -0500

    Reset trust list default to empty string.
---
 configs/agent.ini                                    | 3 ++-
 shibsp/remoting/impl/AbstractHTTPRemotingService.cpp | 3 +--
 shibsp/remoting/impl/AbstractHTTPRemotingService.h   | 1 -
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/configs/agent.ini b/configs/agent.ini
index dfe9f381..05771eac 100644
--- a/configs/agent.ini
+++ b/configs/agent.ini
@@ -10,10 +10,11 @@ defaultLevel = INFO
 #Shibboleth.libcurl = DEBUG
 
 [remoting]
+# For remote Hub, use https://, set authMethod to basic, and provide CA and secret
 baseURL = http://localhost:8080/idp/profile/sp/
 #authMethod = none
 #authCachingCookie = __Host-JSESSIONID
-#tlsCAFile = trustfile.pem
+#tlsCAFile = trustlist.pem
 #secretSourceType = File
 #secretFile = agent.pwd
 
diff --git a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
index 5f13d008..030dd6c7 100644
--- a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
@@ -52,7 +52,6 @@ const char AbstractHTTPRemotingService::AUTH_METHOD_PROP_DEFAULT[] = "none";
 const char AbstractHTTPRemotingService::AUTH_CACHING_COOKIE_PROP_DEFAULT[] = "__Host-JSESSIONID";
 unsigned int AbstractHTTPRemotingService::CONNECT_TIMEOUT_PROP_DEFAULT = 3;
 unsigned int AbstractHTTPRemotingService::TIMEOUT_PROP_DEFAULT = 10;
-const char AbstractHTTPRemotingService::CA_FILE_PROP_DEFAULT[] = "trustlist.pem";
 const bool AbstractHTTPRemotingService::REVOCATION_CHECK_DEFAULT = false;
 
 AbstractHTTPRemotingService::AbstractHTTPRemotingService(ptree& pt)
@@ -79,7 +78,7 @@ AbstractHTTPRemotingService::AbstractHTTPRemotingService(ptree& pt)
     }
 
 
-    m_caFile = props.getString(CA_FILE_PROP_NAME, CA_FILE_PROP_DEFAULT);
+    m_caFile = props.getString(CA_FILE_PROP_NAME, "");
     if (!m_caFile.empty()) {
         AgentConfig::getConfig().getPathResolver().resolve(m_caFile, PathResolver::SHIBSP_CFG_FILE);
 #ifdef WIN32
diff --git a/shibsp/remoting/impl/AbstractHTTPRemotingService.h b/shibsp/remoting/impl/AbstractHTTPRemotingService.h
index 75fc1947..a5017b26 100644
--- a/shibsp/remoting/impl/AbstractHTTPRemotingService.h
+++ b/shibsp/remoting/impl/AbstractHTTPRemotingService.h
@@ -98,7 +98,6 @@ namespace shibsp {
         static const char AUTH_CACHING_COOKIE_PROP_DEFAULT[];
         static unsigned int CONNECT_TIMEOUT_PROP_DEFAULT;
         static unsigned int TIMEOUT_PROP_DEFAULT;
-        static const char CA_FILE_PROP_DEFAULT[];
         static const bool REVOCATION_CHECK_DEFAULT;
 
     protected:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.