[cpp-sp] branch main updated: Windows: fix build

Rod Widdowson rdw at steadingsoftware.com
Mon May 26 15:50:10 UTC 2025


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=df5b0bce5400e2e45b7c5f2d161e20666881786f

The following commit(s) were added to refs/heads/main by this push:
     new df5b0bce Windows: fix build
df5b0bce is described below

commit df5b0bce5400e2e45b7c5f2d161e20666881786f
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon May 26 16:50:05 2025 +0100

    Windows: fix build
---
 shibsp/session/AbstractSessionCache.h          | 5 ++++-
 shibsp/session/impl/FilesystemSessionCache.cpp | 3 +++
 tests/data/remoting/impl/shibboleth.ini        | 5 +++--
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/shibsp/session/AbstractSessionCache.h b/shibsp/session/AbstractSessionCache.h
index 702a5571..b5b256c8 100644
--- a/shibsp/session/AbstractSessionCache.h
+++ b/shibsp/session/AbstractSessionCache.h
@@ -82,13 +82,16 @@ namespace shibsp {
              */
             bool start();
 
-            // SessiomCache API
+            // SessionCache API
             std::string create(SPRequest& request, DDF& session);
             std::unique_lock<Session> find(SPRequest& request, bool checkTimeout, bool ignoreAddress);
             std::unique_lock<Session> find(const char* applicationId, const char* key);
             void remove(SPRequest& request, time_t revocationExp=0);
             void remove(const char* applicationId, const char* key, time_t revocationExp=0);
 
+            // SessionCacheSPI API;
+            virtual std::string create(DDF& sessionData) = 0;
+
         protected:
             /**
              * Constructor.
diff --git a/shibsp/session/impl/FilesystemSessionCache.cpp b/shibsp/session/impl/FilesystemSessionCache.cpp
index a4fccf0a..ef4488e8 100644
--- a/shibsp/session/impl/FilesystemSessionCache.cpp
+++ b/shibsp/session/impl/FilesystemSessionCache.cpp
@@ -43,6 +43,7 @@ namespace {
 namespace shibsp {
     SessionCache* SHIBSP_DLLLOCAL FilesystemSessionCacheFactory(ptree& pt, bool deprecationSupport) {
         //return new FilesystemSessionCache(pt);
+        return nullptr;
     }
 }
 
@@ -54,6 +55,8 @@ SessionCacheSPI::~SessionCacheSPI()
 {
 }
 
+std::string SessionCacheSPI::create(DDF& sessionData) { return std::string(""); }
+
 FilesystemSessionCache::FilesystemSessionCache(const ptree& pt) : AbstractSessionCache(pt)
 {
 }
diff --git a/tests/data/remoting/impl/shibboleth.ini b/tests/data/remoting/impl/shibboleth.ini
index b6384347..8962c1c8 100644
--- a/tests/data/remoting/impl/shibboleth.ini
+++ b/tests/data/remoting/impl/shibboleth.ini
@@ -4,7 +4,8 @@ skipHandlers = true
 skipAttributes = true
 
 [remoting]
-baseURL = https://localhost/idp/profile/sp
+baseURL = https://localhost:8080/idp/profile/sp
+agentID=sp.example.com
 authMethod = basic
 authCachingCookie = __Host-JSESSIONID
 tlsCAFile = ./data/remoting/impl/trustfile.pem
@@ -13,7 +14,7 @@ secretEnv = SHIBSP_AGENT_SECRET
 
 [logging]
 type = console
-defaultLevel = INFO
+defaultLevel = DEBUG
 
 [logging-categories]
 Shibboleth.RemotingService = DEBUG

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list