[java-identity-provider] branch main updated: Fix inverted Constraint on new flowId setter.

Scott Cantor cantor.2 at osu.edu
Thu Mar 20 18:05:15 UTC 2025


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=e0d914f0411ff7b7cfd5875f47bc328a4b992e8e

The following commit(s) were added to refs/heads/main by this push:
     new e0d914f04 Fix inverted Constraint on new flowId setter.
e0d914f04 is described below

commit e0d914f0411ff7b7cfd5875f47bc328a4b992e8e
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Mar 20 14:05:11 2025 -0400

    Fix inverted Constraint on new flowId setter.
---
 .../shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java    | 2 +-
 .../idp/authn/impl/PopulateSubjectCanonicalizationContextTest.java     | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java
index 9a6dbcdb8..c797cb1a9 100644
--- a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java
+++ b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java
@@ -83,7 +83,7 @@ public class SubjectCanonicalizationFlowDescriptor extends AbstractIdentifiableI
         
         flowId = StringSupport.trimOrNull(id);
         if (id != null) {
-            Constraint.isFalse(flowId.startsWith("c14n/"), "Flow ID must begin with c14n/ prefix.");
+            Constraint.isTrue(flowId.startsWith("c14n/"), "Flow ID must begin with c14n/ prefix.");
         }
     }
     
diff --git a/idp-authn-impl/src/test/java/net/shibboleth/idp/authn/impl/PopulateSubjectCanonicalizationContextTest.java b/idp-authn-impl/src/test/java/net/shibboleth/idp/authn/impl/PopulateSubjectCanonicalizationContextTest.java
index dd6505441..729d31d69 100644
--- a/idp-authn-impl/src/test/java/net/shibboleth/idp/authn/impl/PopulateSubjectCanonicalizationContextTest.java
+++ b/idp-authn-impl/src/test/java/net/shibboleth/idp/authn/impl/PopulateSubjectCanonicalizationContextTest.java
@@ -49,7 +49,8 @@ public class PopulateSubjectCanonicalizationContextTest {
                 new SubjectCanonicalizationFlowDescriptor(), new SubjectCanonicalizationFlowDescriptor());
         c14nFlows.get(0).setId("c14n/test1");
         c14nFlows.get(1).setId("c14n/test2");
-        c14nFlows.get(2).setId("c14n/test3");
+        c14nFlows.get(2).setId("test3");        
+        c14nFlows.get(2).setFlowId("c14n/test1");
         for (final var flow : c14nFlows) {
             flow.initialize();
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list