[java-opensaml] branch maint-5.1 updated: Fix null bug in tests.

Brent Putman putmanb at georgetown.edu
Mon Mar 17 19:45:01 UTC 2025


This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch maint-5.1
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=ee023ee303619b6daebde786b1ca13ab42a83738

The following commit(s) were added to refs/heads/maint-5.1 by this push:
     new ee023ee30 Fix null bug in tests.
ee023ee30 is described below

commit ee023ee303619b6daebde786b1ca13ab42a83738
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Mar 17 15:38:03 2025 -0400

    Fix null bug in tests.
    
    Cherry-pick from main a900060572c43b04034c3e98816e4ca522860fa6.
---
 .../impl/HttpServletRequestParametersValidationHandlerTest.java    | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/opensaml-messaging-impl/src/test/java/org/opensaml/messaging/handler/impl/HttpServletRequestParametersValidationHandlerTest.java b/opensaml-messaging-impl/src/test/java/org/opensaml/messaging/handler/impl/HttpServletRequestParametersValidationHandlerTest.java
index ad8dc64ac..8a808e07c 100644
--- a/opensaml-messaging-impl/src/test/java/org/opensaml/messaging/handler/impl/HttpServletRequestParametersValidationHandlerTest.java
+++ b/opensaml-messaging-impl/src/test/java/org/opensaml/messaging/handler/impl/HttpServletRequestParametersValidationHandlerTest.java
@@ -196,8 +196,11 @@ public class HttpServletRequestParametersValidationHandlerTest {
             List<Pair<String, String[]>> requestParams, boolean valid) throws Exception{
 
         MockHttpServletRequest request = new MockHttpServletRequest();
-        for (Pair<String,String[]> requestParam : requestParams) {
-            request.addParameter(requestParam.getFirst(), requestParam.getSecond()); 
+        for (final Pair<String,String[]> requestParam : requestParams) {
+            final String first = requestParam.getFirst();
+            final String[] second = requestParam.getSecond();
+            assert first != null && second != null;
+            request.addParameter(first, second); 
         }
 
         handler.setHttpServletRequestSupplier(() -> request);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list