[java-opensaml] 03/09: Checkstyle.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-5.1
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=5e236ee5e8637165edc98e533a7eb5350e75e006

commit 5e236ee5e8637165edc98e533a7eb5350e75e006
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Sep 18 12:21:28 2024 -0400

    Checkstyle.
---
 .../saml2/testing/SAML2ActionTestingSupport.java    | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/opensaml-testing/src/main/java/org/opensaml/saml/saml2/testing/SAML2ActionTestingSupport.java b/opensaml-testing/src/main/java/org/opensaml/saml/saml2/testing/SAML2ActionTestingSupport.java
index 4c2e897c1..0d684a962 100644
--- a/opensaml-testing/src/main/java/org/opensaml/saml/saml2/testing/SAML2ActionTestingSupport.java
+++ b/opensaml-testing/src/main/java/org/opensaml/saml/saml2/testing/SAML2ActionTestingSupport.java
@@ -48,16 +48,19 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
  * Helper methods for creating/testing SAML 2 objects within profile action tests. When methods herein refer to mock
  * objects they are always objects that have been created via Mockito unless otherwise noted.
  */
-public class SAML2ActionTestingSupport {
+public final class SAML2ActionTestingSupport {
 
     /** ID used for all generated {@link Response} objects. */
-    public final static String REQUEST_ID = "request";
+    @Nonnull public static final  String REQUEST_ID = "request";
 
     /** ID used for all generated {@link Response} objects. */
-    public final static String RESPONSE_ID = "response";
+    @Nonnull public static final String RESPONSE_ID = "response";
 
     /** ID used for all generated {@link Assertion} objects. */
-    public final static String ASSERTION_ID = "assertion";
+    @Nonnull public static final String ASSERTION_ID = "assertion";
+    
+    /** Constructor. */
+    private SAML2ActionTestingSupport() {}
 
     /**
      * Builds an empty response. The ID of the message is {@link ActionTestingSupport#OUTBOUND_MSG_ID}, the issue
@@ -79,8 +82,8 @@ public class SAML2ActionTestingSupport {
     }
 
     /**
-     * Builds an empty artifact response. The ID of the message is {@link ActionTestingSupport#OUTBOUND_MSG_ID}, the issue
-     * instant is 1970-01-01T00:00:00Z and the SAML version is {@link SAMLVersion#VERSION_11}.
+     * Builds an empty artifact response. The ID of the message is {@link ActionTestingSupport#OUTBOUND_MSG_ID},
+     * the issue instant is 1970-01-01T00:00:00Z and the SAML version is {@link SAMLVersion#VERSION_11}.
      * 
      * @return the constructed response
      */
@@ -194,9 +197,7 @@ public class SAML2ActionTestingSupport {
                 XMLObjectProviderRegistrySupport.getBuilderFactory().<AttributeStatement>ensureBuilder(
                         AttributeStatement.DEFAULT_ELEMENT_NAME);
 
-        final AttributeStatement statement = statementBuilder.buildObject();
-
-        return statement;
+        return statementBuilder.buildObject();
     }
 
     /**
@@ -321,7 +322,7 @@ public class SAML2ActionTestingSupport {
      * 
      * @since 4.0.0
      */
-    @Nonnull public static Scoping buildScoping(@Nullable final Integer count, @Nullable Set<String> idplist) {
+    @Nonnull public static Scoping buildScoping(@Nullable final Integer count, @Nullable final Set<String> idplist) {
         final SAMLObjectBuilder<Scoping> scopingBuilder = (SAMLObjectBuilder<Scoping>)
                 XMLObjectProviderRegistrySupport.getBuilderFactory().<Scoping>ensureBuilder(
                         Scoping.DEFAULT_ELEMENT_NAME);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.