[java-identity-provider] branch main updated: Undo API change.

Scott Cantor cantor.2 at osu.edu
Wed Mar 12 16:03:27 UTC 2025


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=aaa884ef2e04cf52c1824f94fe9bd015e413e73b

The following commit(s) were added to refs/heads/main by this push:
     new aaa884ef2 Undo API change.
aaa884ef2 is described below

commit aaa884ef2e04cf52c1824f94fe9bd015e413e73b
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Mar 12 12:03:23 2025 -0400

    Undo API change.
---
 .../java/net/shibboleth/idp/authn/AbstractValidationAction.java    | 7 +------
 .../shibboleth/idp/authn/impl/ValidateExternalAuthentication.java  | 5 ++++-
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java
index 14e20e72a..1a19ffcca 100644
--- a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java
+++ b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java
@@ -385,11 +385,8 @@ public abstract class AbstractValidationAction extends AbstractAuthenticationAct
      * 
      * @param profileRequestContext the current profile request context
      * @param authenticationContext the current authentication context
-     * 
-     * @return the new result
      */
-    @Nonnull protected AuthenticationResult buildAuthenticationResult(
-            @Nonnull final ProfileRequestContext profileRequestContext,
+    protected void buildAuthenticationResult(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final AuthenticationContext authenticationContext) {
         
         final AuthenticationFlowDescriptor attemptedFlow = authenticationContext.getAttemptedFlow();
@@ -427,8 +424,6 @@ public abstract class AbstractValidationAction extends AbstractAuthenticationAct
         
         Constraint.isNotNull(authenticationContext.getParent(),
                 "Parent context cannot be null").addSubcontext(c14n, true);
-        
-        return result;
     }
     
     /**
diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
index e387d52fa..9001c0556 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
@@ -243,7 +243,10 @@ public class ValidateExternalAuthentication extends AbstractAuditingValidationAc
         assert extContext != null;
         filterAttributes(extContext);
         
-        final AuthenticationResult result = buildAuthenticationResult(profileRequestContext, authenticationContext);
+        buildAuthenticationResult(profileRequestContext, authenticationContext);
+        final AuthenticationResult result = authenticationContext.getAuthenticationResult();
+        assert result != null;
+        
         final Instant ai = extContext.getAuthnInstant();
         if (ai != null) {
             result.setAuthenticationInstant(ai);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list