[java-idp-plugin-webauthn] branch main updated: Fix javadoc
Phil Smart
philip.smart at jisc.ac.uk
Fri Mar 7 14:27:01 UTC 2025
This is an automated email from the git hooks/post-receive script.
philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.
View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=32fed99d6f21e9f452431f9820346fe01499a92c
The following commit(s) were added to refs/heads/main by this push:
new 32fed99 Fix javadoc
32fed99 is described below
commit 32fed99d6f21e9f452431f9820346fe01499a92c
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Mar 7 14:26:58 2025 +0000
Fix javadoc
---
.../admin/policy/impl/AbstractAuthenticatorPolicyRule.java | 1 +
.../idp/plugin/authn/webauthn/impl/FilterCredentialsOnPolicy.java | 3 ++-
.../idp/plugin/authn/webauthn/impl/GenerateServerChallenge.java | 7 +++++--
.../shibboleth/idp/plugin/authn/webauthn/impl/WebAuthnEncoder.java | 2 +-
.../storage/impl/IdPStorageServiceCredentialRespository.java | 4 ++--
5 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/policy/impl/AbstractAuthenticatorPolicyRule.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/policy/impl/AbstractAuthenticatorPolicyRule.java
index 0e50e1e..c279591 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/policy/impl/AbstractAuthenticatorPolicyRule.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/policy/impl/AbstractAuthenticatorPolicyRule.java
@@ -52,6 +52,7 @@ public abstract class AbstractAuthenticatorPolicyRule extends AbstractIdentifiab
/** Does this policy rule apply? Default is true. */
@Nonnull private BiPredicate<AAGUID, ProfileRequestContext> activationCondition;
+ /** Constructor.*/
protected AbstractAuthenticatorPolicyRule() {
//default is always true
activationCondition = (prc,claims) -> true;
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/FilterCredentialsOnPolicy.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/FilterCredentialsOnPolicy.java
index b60b9fd..3fb7f32 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/FilterCredentialsOnPolicy.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/FilterCredentialsOnPolicy.java
@@ -110,7 +110,8 @@ public class FilterCredentialsOnPolicy extends AbstractWebAuthnAction<WebAuthnAu
final List<EnhancedCredentialRecord> filteredCredentials =
existingCredentials.stream().filter(credentialToEvaluate -> {
- final CredentialPolicyOutcome outcome = localPolicy.evaluate(credentialToEvaluate, profileRequestContext);
+ final CredentialPolicyOutcome outcome =
+ localPolicy.evaluate(credentialToEvaluate, profileRequestContext);
if (outcome == CredentialPolicyOutcome.ACCEPT) {
log.trace("{} CredentialPolicy '{}' has accepted credential '{}'", getLogPrefix(),
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/GenerateServerChallenge.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/GenerateServerChallenge.java
index db5811d..2e42229 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/GenerateServerChallenge.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/GenerateServerChallenge.java
@@ -114,8 +114,11 @@ public class GenerateServerChallenge extends AbstractWebAuthnAction<BaseWebAuthn
/** The secure random challenge generation strategy.*/
private final IdentifierGenerationStrategy challengeGenerator;
- /** Constructor.
- * @throws ComponentInitializationException */
+ /**
+ * Constructor.
+ *
+ * @throws ComponentInitializationException if there is an error creating the identifier strategy
+ */
public DefaultChallengeGenerator() throws ComponentInitializationException {
try {
challengeGenerator = IdentifierGenerationStrategy.getInstance(ProviderType.SECURE,
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/WebAuthnEncoder.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/WebAuthnEncoder.java
index 34635fe..8243340 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/WebAuthnEncoder.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/WebAuthnEncoder.java
@@ -124,7 +124,7 @@ public final class WebAuthnEncoder {
* Format the given instant into a display friendly string using the given formatter.
*
* @param time the instant to encode
- * @param pattern the date time pattern to use
+ * @param formatter the formatter to use
*
* @return a formatted time string
*
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/IdPStorageServiceCredentialRespository.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/IdPStorageServiceCredentialRespository.java
index 991aa8a..f6583a2 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/IdPStorageServiceCredentialRespository.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/IdPStorageServiceCredentialRespository.java
@@ -694,8 +694,8 @@ public class IdPStorageServiceCredentialRespository extends AbstractIdentifiable
/**
* Constructor.
*
- * @param version the storage record version
- * @param credentials the wrapped set of credentials
+ * @param ver the storage record version
+ * @param creds the wrapped set of credentials
*/
public VersionedCredentialSet(final long ver, @Nonnull final Set<CredentialRecord> creds) {
credentials = Constraint.isNotNull(creds, "credential records can not be null");
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list