[cpp-sp] 01/03: Bug fixes.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=9170c33c57fae88fa2637976f409924c5e22c35b

commit 9170c33c57fae88fa2637976f409924c5e22c35b
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Jun 24 13:22:50 2025 -0400

    Bug fixes.
---
 shibsp/session/impl/FilesystemSessionCache.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/shibsp/session/impl/FilesystemSessionCache.cpp b/shibsp/session/impl/FilesystemSessionCache.cpp
index 5beff1df..7119f15e 100644
--- a/shibsp/session/impl/FilesystemSessionCache.cpp
+++ b/shibsp/session/impl/FilesystemSessionCache.cpp
@@ -251,8 +251,8 @@ DDF FilesystemSessionCache::cache_read(
             if (m_spilog.isInfoEnabled()) {
                 string ts(date::format("%FT%TZ", chrono::system_clock::from_time_t(lastAccess)));
                 m_spilog.info("session (%s) expired for inactivity, timeout (%lu), last access (%s)", key, timeout, ts.c_str());
-                cache_remove(request, key);
             }
+            cache_remove(request, key);
             return obj;
         }
     }
@@ -266,10 +266,10 @@ DDF FilesystemSessionCache::cache_read(
         return obj;
     }
 
-    const char* appId = obj["appId"].string();
+    const char* appId = obj["app_id"].string();
     if (strcmp(applicationId, appId)) {
-        obj.destroy();
         m_spilog.warn("session (%s) issued for application (%s), accessed via application (%s)", key, appId, applicationId);
+        obj.destroy();
         return obj;
     }
 
@@ -277,8 +277,8 @@ DDF FilesystemSessionCache::cache_read(
     if (client_addr) {
         const char* addr = obj["addr"].string();
         if (addr && strcmp(client_addr, addr)) {
-            obj.destroy();
             m_spilog.info("session (%s) invalid, bound to address (%s), accessed from (%s)", key, addr, client_addr);
+            obj.destroy();
             cache_remove(request, key);
             return obj;
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.