[java-idp-oidc] 25/31: JOIDC-222 - Support for OpenID Federation

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch dev/JOIDC-222
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=c5a735935b2ff50ddec5c7384d12b2ebb63b20a8

commit c5a735935b2ff50ddec5c7384d12b2ebb63b20a8
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Fri May 2 12:50:27 2025 +0300

    JOIDC-222 - Support for OpenID Federation
    
    https://shibboleth.atlassian.net/browse/JOIDC-222
    
    Drop 'iss' -parameter out from the fetch subordinate statement request
    - The previously mandatory parameter was dropped out in draft 39.
---
 .../DefaultSubordinateStatementEndpointExtractionStrategy.java    | 2 +-
 .../oidc/op/profile/flow/oidfed/AbstractFederationFlowTest.java   | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultSubordinateStatementEndpointExtractionStrategy.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultSubordinateStatementEndpointExtractionStrategy.java
index c5d6920a..b4e19e19 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultSubordinateStatementEndpointExtractionStrategy.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultSubordinateStatementEndpointExtractionStrategy.java
@@ -139,7 +139,7 @@ public class DefaultSubordinateStatementEndpointExtractionStrategy extends Abstr
         }
 
         try {
-            return new URI(federationFetchEndpoint + "?iss=" + issuerEntityId + "&sub=" + subjectEntityId);
+            return new URI(federationFetchEndpoint + "?sub=" + subjectEntityId);
         } catch (final URISyntaxException e) {
             log.error("Could not build URI for fetching subordinate entity statement", e);
         }
diff --git a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/AbstractFederationFlowTest.java b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/AbstractFederationFlowTest.java
index ee5a9464..3bcaa527 100644
--- a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/AbstractFederationFlowTest.java
+++ b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/AbstractFederationFlowTest.java
@@ -147,8 +147,8 @@ public class AbstractFederationFlowTest extends AbstractOidcFlowTest {
         return entityId + "/.well-known/openid-federation";
     }
 
-    protected String subordinateStatementUrl(final String fetchEndpoint, final String issuer, final String subject) {
-        return fetchEndpoint + "?iss=" + issuer + "&sub=" + subject;
+    protected String subordinateStatementUrl(final String fetchEndpoint, final String subject) {
+        return fetchEndpoint + "?sub=" + subject;
     }
 
     protected void mapResponse(final String requestUri, final ClassicHttpResponse classicResponse) throws IOException {
@@ -229,7 +229,7 @@ public class AbstractFederationFlowTest extends AbstractOidcFlowTest {
         try {
             mapResponse(entityConfigurationUrl(clientId), mockResponse(rpEntityConfiguration(clientId)));
             mapResponse(entityConfigurationUrl(anchorId), mockResponse(trustedAnchorConfiguration()));
-            mapResponse(subordinateStatementUrl(anchorFetchEndpoint, anchorId, clientId),
+            mapResponse(subordinateStatementUrl(anchorFetchEndpoint, clientId),
                     mockResponse(subordinateStatement(clientId)));
         } catch (UnsupportedOperationException | IOException | URISyntaxException e) {
             Assert.fail("Could not initialize mock HTTP client", e);
@@ -240,7 +240,7 @@ public class AbstractFederationFlowTest extends AbstractOidcFlowTest {
         try {
             mapResponse(entityConfigurationUrl(clientId), mockResponse(rpEntityConfiguration(clientId, metadata)));
             mapResponse(entityConfigurationUrl(anchorId), mockResponse(trustedAnchorConfiguration()));
-            mapResponse(subordinateStatementUrl(anchorFetchEndpoint, anchorId, clientId),
+            mapResponse(subordinateStatementUrl(anchorFetchEndpoint, clientId),
                     mockResponse(subordinateStatement(clientId)));
         } catch (UnsupportedOperationException | IOException | URISyntaxException e) {
             Assert.fail("Could not initialize mock HTTP client", e);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.