[js-embedded-discovery] 02/02: EDS-88 Don't render Help link if helpURL=null

Rod Widdowson rdw at steadingsoftware.com
Mon Jun 9 18:02:02 UTC 2025


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository js-embedded-discovery.

View the commit online:
http://git.shibboleth.net/view/?p=js-embedded-discovery.git;a=commit;h=3bb1fe6be12ee97ef62329971555731a0f81bffe

commit 3bb1fe6be12ee97ef62329971555731a0f81bffe
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon Jun 9 18:59:12 2025 +0100

    EDS-88 Don't render Help link if helpURL=null
    
    https://shibboleth.atlassian.net/browse/EDS-88
---
 src/javascript/idpselect.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/javascript/idpselect.js b/src/javascript/idpselect.js
index bf24b70..cf4f9c7 100644
--- a/src/javascript/idpselect.js
+++ b/src/javascript/idpselect.js
@@ -1124,11 +1124,13 @@ function IdPSelectUI() {
     */
 
     var buildHelpText = function(containerDiv) {
-        var aval = document.createElement('a');
-        aval.href = helpURL;
-        aval.appendChild(document.createTextNode(getLocalizedMessage('helpText')));
-        setClass(aval, 'HelpButton');
-        containerDiv.appendChild(aval);
+	if (helpURL != null) {
+            var aval = document.createElement('a');
+            aval.href = helpURL;
+            aval.appendChild(document.createTextNode(getLocalizedMessage('helpText')));
+            setClass(aval, 'HelpButton');
+            containerDiv.appendChild(aval);
+	}
     } ;
     
     /**

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list