[java-oidc-common] branch main updated: JCOMOIDC-132 - Two setter methods for OIDC.SSO are missing -predicate postfix

Henri Mikkonen henri.mikkonen at iki.fi
Thu Jun 5 12:53:51 UTC 2025


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=165d71e93c32895935e15ae2a209f209dd6e884c

The following commit(s) were added to refs/heads/main by this push:
     new 165d71e  JCOMOIDC-132 - Two setter methods for OIDC.SSO are missing -predicate postfix
165d71e is described below

commit 165d71e93c32895935e15ae2a209f209dd6e884c
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Thu Jun 5 15:52:01 2025 +0300

    JCOMOIDC-132 - Two setter methods for OIDC.SSO are missing -predicate postfix
    
    https://shibboleth.atlassian.net/browse/JCOMOIDC-132
    
    Deprecated two wrongly named setters and added two new ones with the postfix.
---
 .../DefaultOIDCAuthorizationConfiguration.java     | 37 +++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/DefaultOIDCAuthorizationConfiguration.java b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/DefaultOIDCAuthorizationConfiguration.java
index bfeddf9..e80d0eb 100644
--- a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/DefaultOIDCAuthorizationConfiguration.java
+++ b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/config/impl/DefaultOIDCAuthorizationConfiguration.java
@@ -40,6 +40,8 @@ import net.shibboleth.shared.logic.Constraint;
 import net.shibboleth.shared.logic.ConstraintViolationException;
 import net.shibboleth.shared.logic.FunctionSupport;
 import net.shibboleth.shared.logic.PredicateSupport;
+import net.shibboleth.shared.primitive.DeprecationSupport;
+import net.shibboleth.shared.primitive.DeprecationSupport.ObjectType;
 import net.shibboleth.shared.primitive.StringSupport;
 
 /**
@@ -295,8 +297,24 @@ public class DefaultOIDCAuthorizationConfiguration extends AbstractOIDCSSOConfig
      * @param condition condition to set
      * 
      * @since 2.2.0
+     *
+     * @deprecated
      */
+    @Deprecated(since = "3.3.0", forRemoval=true)
     public void setRetrieveUserInfoEndpointClaims(@Nonnull final Predicate<ProfileRequestContext> condition){
+        DeprecationSupport.warn(ObjectType.METHOD, "setRetrieveUserInfoEndpointClaims", null,
+                "setRetrieveUserInfoEndpointClaimsPredicate");
+        setRetrieveUserInfoEndpointClaimsPredicate(condition);
+    }
+
+    /**
+     * Set condition for whether to make a request to the UserInfo Endpoint to obtain authenticated End-User claims.
+     *
+     * @param condition condition to set
+     *
+     * @since 3.3.0
+     */
+    public void setRetrieveUserInfoEndpointClaimsPredicate(@Nonnull final Predicate<ProfileRequestContext> condition){
         retrieveUserInfoEndpointClaims = Constraint.isNotNull(condition, "Condition cannot be null");
     }
 
@@ -874,11 +892,28 @@ public class DefaultOIDCAuthorizationConfiguration extends AbstractOIDCSSOConfig
      * @param condition condition to set
      * 
      * @since 2.2.0
+     *
+     * @deprecated
      */
+    @Deprecated(since = "3.3.0", forRemoval=true)
     public void setTlsServerValidationSufficient(@Nonnull final Predicate<ProfileRequestContext> condition) {
+        DeprecationSupport.warn(ObjectType.METHOD, "setTlsServerValidationSufficient", null,
+                "setTlsServerValidationSufficientPredicate");
+        setTlsServerValidationSufficientPredicate(condition);
+    }
+
+    /**
+     * Set the predicate to determine whether TLS server validation alone is sufficient to verify the id_token (true),
+     * or whether the id_token's signature should be validated (false).
+     *
+     * @param condition condition to set
+     *
+     * @since 3.3.0
+     */
+    public void setTlsServerValidationSufficientPredicate(@Nonnull final Predicate<ProfileRequestContext> condition) {
         tlsServerValidationOnlyPredicate = Constraint.isNotNull(condition, "Condition cannot be null");
     }
-    
+
     /** {@inheritDoc} */
     @Override
     public boolean isTlsServerValidationSufficient(@Nullable final ProfileRequestContext profileRequestContext) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list