[java-idp-integration-tests] 02/02: Suppress warnings

Tom Zeller tzeller at dragonacea.biz
Tue Jun 3 23:22:28 UTC 2025


This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch main
in repository java-idp-integration-tests.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-integration-tests.git;a=commit;h=feb069e918c11cb63756da9f99a0b595de9eb3a7

commit feb069e918c11cb63756da9f99a0b595de9eb3a7
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Tue Jun 3 18:22:12 2025 -0500

    Suppress warnings
---
 src/test/java/net/shibboleth/idp/integration/tests/BaseTest.java     | 4 ++--
 .../idp/integration/tests/oidc/ConformanceSuiteContainer.java        | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/test/java/net/shibboleth/idp/integration/tests/BaseTest.java b/src/test/java/net/shibboleth/idp/integration/tests/BaseTest.java
index 82ee0fa..8a03429 100644
--- a/src/test/java/net/shibboleth/idp/integration/tests/BaseTest.java
+++ b/src/test/java/net/shibboleth/idp/integration/tests/BaseTest.java
@@ -1957,8 +1957,8 @@ public abstract class BaseTest {
         // Password form input field
         final WebElement password = driver.findElement(By.name("j_password"));
         // Cached username
-        final String cachedUser = username.getAttribute("value");
-        log.trace("Cached username '{}'", username.getAttribute("value"));
+        final String cachedUser = username.getDomAttribute("value");
+        log.trace("Cached username '{}'", username.getDomAttribute("value"));
         if (cachedUser == null) {
             // Username form field is empty, so enter the username
             username.sendKeys(user);
diff --git a/src/test/java/net/shibboleth/idp/integration/tests/oidc/ConformanceSuiteContainer.java b/src/test/java/net/shibboleth/idp/integration/tests/oidc/ConformanceSuiteContainer.java
index 269ebeb..045e441 100644
--- a/src/test/java/net/shibboleth/idp/integration/tests/oidc/ConformanceSuiteContainer.java
+++ b/src/test/java/net/shibboleth/idp/integration/tests/oidc/ConformanceSuiteContainer.java
@@ -73,6 +73,7 @@ public class ConformanceSuiteContainer extends AbstractIdentifiableInitializable
     @Nonnull
     protected String opPort = "443";
 
+    @SuppressWarnings("resource")
     @Override
     protected void doInitialize() throws ComponentInitializationException {
 
@@ -119,8 +120,7 @@ public class ConformanceSuiteContainer extends AbstractIdentifiableInitializable
         }
 
         // TODO does wait here work properly ?
-        // TODO closeable
-        container = new DockerComposeContainer(getId(), pathToDockerComposeYML.toFile()) //
+        container = new DockerComposeContainer<>(getId(), pathToDockerComposeYML.toFile()) //
                 .withExposedService( //
                         "httpd", //
                         8443, //
@@ -354,6 +354,7 @@ public class ConformanceSuiteContainer extends AbstractIdentifiableInitializable
         log.debug("{} Stopping ...", getLogPrefix());
         container.stop();
         log.info("{} Stopped", getLogPrefix());
+        container.close();
     }
 
     @Override

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list