[java-plugin-shibd] branch main updated: Avoid explicit value check for session ID.

Scott Cantor cantor.2 at osu.edu
Thu Jan 23 15:24:44 UTC 2025


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
http://git.shibboleth.net/view/?p=java-plugin-shibd.git;a=commit;h=78c3fa2528544cff3eb96dff8ee94bb4c234a38b

The following commit(s) were added to refs/heads/main by this push:
     new 78c3fa2  Avoid explicit value check for session ID.
78c3fa2 is described below

commit 78c3fa2528544cff3eb96dff8ee94bb4c234a38b
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Jan 23 10:24:41 2025 -0500

    Avoid explicit value check for session ID.
---
 sp-conf-impl/src/test/java/net/shibboleth/sp/flows/PingFlowTest.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/PingFlowTest.java b/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/PingFlowTest.java
index 49fc7d5..c33534f 100644
--- a/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/PingFlowTest.java
+++ b/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/PingFlowTest.java
@@ -88,8 +88,7 @@ public class PingFlowTest extends AbstractSPFlowTest {
         final DDF obj = assertOutputMessageSuccess(result);
         assert obj != null;
         
-        // Seems the mocks create a Java session ID of "1", we'll see if that holds.
-        Assert.assertEquals(obj.getmember("cached_auth").string(), "1");
+        Assert.assertNotNull(obj.getmember("cached_auth").string());
         
         final Long time = obj.getmember("epoch").longinteger();
         Assert.assertTrue(time != null && time <= Instant.now().toEpochMilli() / 1000);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list