[java-idp-oidc] branch main updated: JOIDC-237 - IllegalStateException in view-state CallFrontChannelLogoutUriView

Henri Mikkonen henri.mikkonen at iki.fi
Wed Jan 22 08:21:42 UTC 2025


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=5122bcbc16cfe0023cfc0b7a31f701ed5f59435a

The following commit(s) were added to refs/heads/main by this push:
     new 5122bcbc JOIDC-237 - IllegalStateException in view-state CallFrontChannelLogoutUriView
5122bcbc is described below

commit 5122bcbc16cfe0023cfc0b7a31f701ed5f59435a
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Jan 22 10:16:27 2025 +0200

    JOIDC-237 - IllegalStateException in view-state CallFrontChannelLogoutUriView
    
    https://shibboleth.atlassian.net/browse/JOIDC-237
    
    Moved the 'EncodeMessage' -action from 'DoFrontChannelLogout' -state into 'LogoutPending' -state.
    This means that it'll be called solely when front-channel logout propagation is performed with
    'frontChannelSuccess' option set to 'false', which is the default. If the option is set to true,
    then the front channel logout URI is called via iframe in the 'CallFrontChannelLogoutUriView' -view.
    In that case, the response doesn't need to be encoded in the same way, as the logout URI to the iframe
    is obtained directly from the outbound message object.
---
 .../idp/flows/logoutprop/oidc/oidc-logout-propagation-flow.xml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/logoutprop/oidc/oidc-logout-propagation-flow.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/logoutprop/oidc/oidc-logout-propagation-flow.xml
index b3038cbf..fdee482d 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/logoutprop/oidc/oidc-logout-propagation-flow.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/logoutprop/oidc/oidc-logout-propagation-flow.xml
@@ -42,7 +42,6 @@
 
     <action-state id="DoFrontChannelLogout">
         <evaluate expression="FormOutboundMessage" />
-        <evaluate expression="EncodeMessage" />
         <evaluate expression="RevokeTokenChain"/>
         <evaluate expression="PostResponsePopulateAuditContext" />
         <evaluate expression="'proceed'"/>
@@ -104,6 +103,7 @@
     <!-- Successful terminal state (success meaning outbound LogoutRequest encoded). -->
     <end-state id="LogoutPending">
         <on-entry>
+            <evaluate expression="EncodeMessage" />
             <evaluate expression="PostResponsePopulateAuditContext" />
             <evaluate expression="WriteAuditLog" />
             <evaluate expression="RecordResponseComplete" />

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list